#82 - Authenticate with discord #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up orbat view (ARCOMM#42)
TomBurch
commented
Jun 14, 2021
TomBurch
commented
Jun 21, 2021
Comment on lines
+36
to
+42
| if (!auth()->guest()) { | ||
| if (is_null(auth()->user()->discord_id)) { | ||
| auth()->user()->discord_id = $user->id; | ||
| auth()->user()->save(); | ||
| return redirect('/hub'); | ||
| } | ||
| } |
There was a problem hiding this comment.
For migrating existing users
TomBurch
commented
Jun 21, 2021
Comment on lines
+39
to
+44
| $user = User::where('steam_id', $data->id)->first(); | ||
|
|
||
| if (is_null($user)) { | ||
| return [ | ||
| 'error' => 'Account not found.' | ||
| ]; |
There was a problem hiding this comment.
This will only login existing users - new users can't authenticate with steam
| $user = User::findOrFail($request->user_id); | ||
|
|
||
| return $this->update($request, $user); | ||
| // |
There was a problem hiding this comment.
These were used by admins in the User display to update permissions
Now that permissions are handled through Discord roles the ability to update permissions through the site was removed
The reason that I've left the functions there, but with no functionality, is I believe User is defined as a REST resource (so should implement CRUD methods)
|
lgtm Plans for release:
|
TomBurch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.