fix(core-transaction-pool): keep previously forged transaction (#4390)

ArkEcosystem · May 17, 2021 · 2789331 · 2789331
1 parent ee8c5e3
commit 2789331
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/__tests__/unit/core-transaction-pool/service.test.ts b/__tests__/unit/core-transaction-pool/service.test.ts
@@ -1,7 +1,7 @@
 import { Container, Contracts, Enums } from "@arkecosystem/core-kernel";
 import { Identities, Managers, Transactions } from "@arkecosystem/crypto";
 
-import { Service } from "@packages/core-transaction-pool/src/service";
+import { Service } from "../../../packages/core-transaction-pool/src/service";
 
 const configuration = {
     getRequired: jest.fn(),

diff --git a/packages/core-transaction-pool/src/service.ts b/packages/core-transaction-pool/src/service.ts
@@ -154,6 +154,10 @@ export class Service implements Contracts.TransactionPool.Service {
             const expiredHeight: number = lastHeight - maxTransactionAge;
 
             for (const { height, id, serialized } of this.storage.getAllTransactions()) {
+                if (previouslyForgedTransactions.find((t) => t.id === id)) {
+                    continue;
+                }
+
                 if (height > expiredHeight) {
                     try {
                         const previouslyStoredTransaction = Transactions.TransactionFactory.fromBytes(serialized);