Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-transaction-pool): keep previously forged transaction #4390

Merged

Conversation

rainydio
Copy link
Contributor

Summary

Do not remove just recently applied transaction from storage.

Checklist

  • Ready to be merged

@rainydio rainydio marked this pull request as ready for review May 17, 2021 09:03
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2021

Codecov Report

Merging #4390 (b48d0d1) into develop (ee8c5e3) will decrease coverage by 1.33%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4390      +/-   ##
===========================================
- Coverage    95.89%   94.56%   -1.34%     
===========================================
  Files          738      738              
  Lines        18339    18341       +2     
  Branches      2236     2236              
===========================================
- Hits         17587    17344     -243     
- Misses         556      801     +245     
  Partials       196      196              
Flag Coverage Δ
functional ?
integration 9.54% <0.00%> (-0.01%) ⬇️
unit 94.48% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-transaction-pool/src/service.ts 84.73% <0.00%> (-0.91%) ⬇️
...rc/migrations/20190307000000-drop-wallets-table.ts 0.00% <0.00%> (-100.00%) ⬇️
...c/migrations/20180305200000-create-rounds-table.ts 0.00% <0.00%> (-100.00%) ⬇️
...c/migrations/20180305300000-create-blocks-table.ts 0.00% <0.00%> (-100.00%) ⬇️
.../migrations/20180305100000-create-wallets-table.ts 0.00% <0.00%> (-100.00%) ⬇️
.../migrations/20201013000000-create-wallets-table.ts 0.00% <0.00%> (-100.00%) ⬇️
...igrations/20190626000000-enforce-chained-blocks.ts 0.00% <0.00%> (-100.00%) ⬇️
...grations/20201103000000-set-autovacuum-settings.ts 0.00% <0.00%> (-100.00%) ⬇️
...rations/20191003000000-migrate-vendor-field-hex.ts 0.00% <0.00%> (-100.00%) ⬇️
...ations/20180305400000-create-transactions-table.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee8c5e3...b48d0d1. Read the comment docs.

@air1one air1one merged commit 2789331 into develop May 17, 2021
@air1one air1one deleted the fix/core-transaction-pool/keep-previously-forged-transaction branch May 17, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants