fix(crypto): use anyOf for transactions schema
#2894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2894 +/- ##
========================================
Coverage 67.66% 67.66%
========================================
Files 405 405
Lines 9740 9740
Branches 450 492 +42
========================================
Hits 6591 6591
+ Misses 3115 3111 -4
- Partials 34 38 +4
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Aug 28, 2019
ghost
deleted the
ghost
mentioned this pull request
2 tasks
spkjp
added a commit
that referenced
this pull request
Sep 4, 2019
vasild
added a commit
that referenced
this pull request
Sep 5, 2019
…k-chained-verbose * ArkEcosystem/core/develop: test: mock missing wsServer release: 2.5.24 (#2908) fix(core-p2p): terminate blocked client connections fix(core-p2p): drop connections with malformed messages fix(core-api): return block timestamp for v2 transactions (#2906) fix(core-blockchain): only shift milestoneHeights[] if at that height (#2904) fix(crypto): use `anyOf` for transactions schema (#2894) fix(core-webhooks): cast params in condition checks (#2887) feat(core-p2p): use compression on the p2p level (#2886)
vasild
added a commit
that referenced
this pull request
Sep 5, 2019
…ly-chained-check * ArkEcosystem/core/develop: test: mock missing wsServer release: 2.5.24 (#2908) fix(core-p2p): terminate blocked client connections fix(core-p2p): drop connections with malformed messages fix(core-api): return block timestamp for v2 transactions (#2906) fix(core-blockchain): only shift milestoneHeights[] if at that height (#2904) fix(crypto): use `anyOf` for transactions schema (#2894) fix(core-webhooks): cast params in condition checks (#2887) feat(core-p2p): use compression on the p2p level (#2886)
|
Not fixed :/ See #2888 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
anyOflooks for the first matching schema and exits early.oneOfalways matches against each schema and will error when there's more than 1 match. This is not only slower but also sporadically causing issues when a transaction payload matches against multiple schemas.Resolves #2888
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
developbranch, not themasterbranchIf adding a new feature, the PR's description includes: