Fix wradlib

[kmuehlbauer]

• closes wradlib release 1.0.0 #722
• fixes links to wradlib
• fixes import of read_rainbow

[scollis]

Thanks @kmuehlbauer !! @zssherman can you review.. Download the branch and make sure we can still read X-SAPR2

[zssherman]

Sounds good, doing that now.

[zssherman]

@scollis Sorry for clarification, X-SAPR2 is gamic, did you still want me to test that or did you have a rainbow file I should test too?

[kmuehlbauer]

@zssherman only rainbow is effected.

[zssherman]

@kmuehlbauer Makes sense. Ah I notice that link changes, I changed the wradlib link in the README, didn't realize there were more. Glad you caught those. @scollis The changes look good to me and the CI is passing, I just need some rainbow data if you want me to be completely sure, otherwise I see no issues.

[kmuehlbauer]

@zssherman there is one rainbow file in wradlib/wradlib-data repo on github, if you want to test.

[kmuehlbauer]

@zssherman Only the function name changed, no functionality. Should work.

[zssherman]

Perfect! Thanks @kmuehlbauer !

[scollis]

Ahh cool.. for some reason I thought GAMIC had rainbow as an underlying format.. @zssherman just double check using the rainbow file..

[zssherman]

Looks good, I tested it with wradlib=1.0.0 and wradlib-0.11.3 and it worked for both.

[scollis]

Thanks! accepting

[meteoswiss-mdr]

Hi all,

@kmuehlbauer , @scollis, there was an issue with the wradlib library. When passing the file name instead of the file handle the file was not properly closed after reading. That issue has been corrected but it did not make it to version 1.0 of wradlib so whoever uses wradlib 1.0 in Py-ART (as myself) will not close the files properly
I propose to solve the issue by passing the file handle, not the file name to wradlib, i.e.:
with open(filename, 'rb') as fid:
rbf = read_rainbow(fid, loaddata=True)
Greetings from Switzerland!

[scollis]

Good morning @meteoswiss-mdr ! Sounds like a good change. Feel free to submit a PR or we can do so next week (DoE meeting this week).

[meteoswiss-mdr]

It is such a small change that I let you do it yourselves.