Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osEventFlagsSet fails with called from ISR #12

Closed
ghost opened this issue Jun 12, 2018 · 2 comments
Closed

osEventFlagsSet fails with called from ISR #12

ghost opened this issue Jun 12, 2018 · 2 comments
Assignees
Labels

Comments

@ghost
Copy link

ghost commented Jun 12, 2018

if (xEventGroupSetBitsFromISR (hEventGroup, (EventBits_t)flags, &yield)  != pdFAIL) {
  rflags = (uint32_t)osErrorResource;
} else {
  rflags = flags;
  portYIELD_FROM_ISR (yield);
}
@JonatanAntoni JonatanAntoni self-assigned this Jun 13, 2018
@JonatanAntoni
Copy link
Member

Hi @shaper-street,
thanks for reporting this issue and the fix.

It took me a really close look to spot the little difference. Hence I'd like to ask you to be slightly more verbose.

I see the problem as following:
The current implementation returns always osErrorResource when the actual call to xEventGroupSetBitsFromISR succeeds. The return value check is reversed.

VladimirUmek added a commit that referenced this issue Jun 13, 2018
Fix for issue #12 verified. Many thanks for the
@VladimirUmek
Copy link
Collaborator

Closing issue as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants