Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation of SYMGS+SPMV was using x_old to calculate the spmv (L * old_x + (D+U) * new_x), It was totally wrong due to the expression is equal to the value of source (i.e., b). The mathematical proof is that the backward induction is exact (U+D)x’’+Lx’=b.
It can also be proved by the applied code: ComputeSYMGS.cpp:764-768
totalContribution += xv[row] * currentDiagonal; while xv[row]=(rv[row] - totalContribution)/currentDiagonal, which gives totalContribution =rv[row]
Now we ensure all x are new, and we calculate Ax by (L+D+U)x = b-Lx_pre+Lx to reuse the data calculated in forward sweep.