sharpen up definition of the extent of the stack #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed, we should go ahead and finally merge this. |
Currently, the SP is specified to lie between stack-base inclusive, and stack-limit exclusive. Having the stack-limit be exclusive to the stack pointer is confusing at best, so for clarity this patch changes the definition to b stack-limit inclusive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the SP is specified to lie between stack-base inclusive, and
stack-limit exclusive. Having the stack-limit be exclusive to the stack pointer
is confusing at best, so for clarity this patch changes the definition to be
stack-limit inclusive.