Skip to content

Commit

Permalink
rockchip: Disable binary generation for all SoCs.
Browse files Browse the repository at this point in the history
All supported Rockchip SoCs (RK3288, RK3328, RK3368 and RK3399)
have non-continuous memory areas in the linker script with a huge
gap between them. This results in extremely padded binary images
with a size of about 4 GiB.

E.g. on the RK3399 we have the following memory areas (and base addresses):
RAM (0x1000), SRAM (0xFF8C0000), and PMUSRAM (0xFF3B0000).

Consumers of the TF-A project (e.g. coreboot or U-Boot) therefore
use the ELF image instead, which has a size of a few hundred kBs.

In order to prevent the generation of a huge and useless file,
this patch disables the binary generation for all affected Rockchip
SoCs.

Signed-off-by: Christoph Müllner <christophm30@gmail.com>
Change-Id: I4ac65bdf1e598c3e1a59507897d183aee9a36916
  • Loading branch information
cmuellner committed May 2, 2019
1 parent 9e4609f commit 33218d2
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 0 deletions.
2 changes: 2 additions & 0 deletions plat/rockchip/rk3288/platform.mk
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ RK_PLAT := plat/rockchip
RK_PLAT_SOC := ${RK_PLAT}/${PLAT}
RK_PLAT_COMMON := ${RK_PLAT}/common

DISABLE_BIN_GENERATION := 1

PLAT_INCLUDES := -I${RK_PLAT_COMMON}/ \
-I${RK_PLAT_COMMON}/include/ \
-I${RK_PLAT_COMMON}/aarch32/ \
Expand Down
2 changes: 2 additions & 0 deletions plat/rockchip/rk3328/platform.mk
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ RK_PLAT := plat/rockchip
RK_PLAT_SOC := ${RK_PLAT}/${PLAT}
RK_PLAT_COMMON := ${RK_PLAT}/common

DISABLE_BIN_GENERATION := 1

PLAT_INCLUDES := -Idrivers/arm/gic/common/ \
-Idrivers/arm/gic/v2/ \
-I${RK_PLAT_COMMON}/ \
Expand Down
2 changes: 2 additions & 0 deletions plat/rockchip/rk3368/platform.mk
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ RK_PLAT := plat/rockchip
RK_PLAT_SOC := ${RK_PLAT}/${PLAT}
RK_PLAT_COMMON := ${RK_PLAT}/common

DISABLE_BIN_GENERATION := 1

PLAT_INCLUDES := -I${RK_PLAT_COMMON}/ \
-I${RK_PLAT_COMMON}/include/ \
-I${RK_PLAT_COMMON}/aarch64/ \
Expand Down
2 changes: 2 additions & 0 deletions plat/rockchip/rk3399/platform.mk
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ RK_PLAT := plat/rockchip
RK_PLAT_SOC := ${RK_PLAT}/${PLAT}
RK_PLAT_COMMON := ${RK_PLAT}/common

DISABLE_BIN_GENERATION := 1

PLAT_INCLUDES := -I${RK_PLAT_COMMON}/ \
-I${RK_PLAT_COMMON}/include/ \
-I${RK_PLAT_COMMON}/aarch64/ \
Expand Down

0 comments on commit 33218d2

Please sign in to comment.