Provide a mechanism to configure the initial parameters of the #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdhost controller (initial clock rate, bus width), and then configure those parameters. This change allows warm reboots of UEFI on Raspberry Pi 3B+ where existing code often fails with "unknown error". See discussion at: pftf/RPi3#24 The basic problem was that a number of SD commands are issued before sensible initialization configurations have been committed. I suspect that the primary culprit is setting the "slow card" bit, but the initial clock rate also seemed wrong, as did the missing voltage settings.
|
Hello @rob-the-dude! Thank you for your contribution to Trusted Firmware-A! The TF-A project has now migrated to www.trustedfirmware.org. Our GitHub repo will remain accessible as a Read-Only mirror but we have changed the way we accept contributions for the project. How do I contribute patches to TF-A?We have a Getting started article which we hope will make everything very straightforward! And if you would like more details you can always refer to the contributing guidelines. A quick overview:
What if I face any problems?We have many channels through which you can contact us:
We are looking forward to seeing your patch submitted to trustedfirmware.org! The Trusted Firmware-A team |
|
This fix has been merged to TF-A via: https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/20297 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sdhost controller (initial clock rate, bus width), and then configure those parameters.
This change allows warm reboots of UEFI on Raspberry Pi 3B+ where existing code often fails with "unknown error". See discussion at:
The basic problem was that a number of SD commands are issued before sensible initialization configurations have been committed. I suspect that the primary culprit is setting the "slow card" bit, but the initial clock rate also seemed wrong, as did the missing voltage settings.