-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This commits enables the warning when setting `owner` prop. Instead the users should migrate to using the new tag system. The prop will be removed in the future. Change-Id: Icd5f944f6da659a0448ada7b7c17f02ad43b4f13
- Loading branch information
1 parent
18c5c52
commit 3611363
Showing
5 changed files
with
52 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# `deprecated-owner-prop` warning | ||
|
||
## Warns when a module sets `owner` | ||
|
||
## Problematic code: | ||
|
||
```bp | ||
bob_binary { | ||
name: "bin_tagable_defaults", | ||
srcs: ["src.cpp"], | ||
defaults: ["tagable_defaults"], | ||
owner: "baz", | ||
} | ||
``` | ||
|
||
## Correct code: | ||
|
||
```bp | ||
bob_binary { | ||
name: "bin_tagable_defaults", | ||
srcs: ["src.cpp"], | ||
defaults: ["tagable_defaults"], | ||
tags: ["owner:baz"], | ||
} | ||
``` | ||
|
||
## Rationale: | ||
|
||
We are trying to remove Bob attributes which do not have a sensible translation to Bazel. In this instance the generic tagging system in Bazel provides a sensible alternative. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters