lisa.tests.cpufreq.schedutil: Add LargeStepUp test for ramp boost fea… #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglas-raillard-arm
force-pushed
the
schedutil_em
branch
from
33cbfae
to
e2010a4
Compare
douglas-raillard-arm
force-pushed
the
schedutil_em
branch
from
e2010a4
to
4b15878
Compare
| # Tolerate a few bad samples that added too much boost | ||
| passed_shape = bad_shape_pct < bad_samples_threshold_pct | ||
|
|
||
| passed = passed_overhead and passed_shape |
There was a problem hiding this comment.
Would it make sense to split these into two separate tests? We'd get finer grained results.
There was a problem hiding this comment.
I'm not sure if that would really help, all these checks are just checking the overall shape of the signal. If I could simulate the signals with 100% accuracy, they would all go away and replaced by a Series equality check.
|
|
||
| # Ensure accurate duty cycle and idle state misprediction on some | ||
| # boards. This helps having predictable execution. | ||
| with target.disable_idle_states(): |
There was a problem hiding this comment.
We keep carrying over an explanation as to why we do this... Perhaps we should stick it in a load-tracking specific "I care about signals so give me a white room` context manager.
There was a problem hiding this comment.
Good cleanup idea, added to the TODO list
douglas-raillard-arm
force-pushed
the
schedutil_em
branch
from
4b15878
to
ee8bcac
Compare
…ture Provide a test for the ramp boost feature as posted on LKML. This test will mostly catch cases where schedutil is not called as often as expected, since it reads most of the signals from the kernel instead of guessing them.
douglas-raillard-arm
force-pushed
the
schedutil_em
branch
from
ee8bcac
to
b282ec9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ture
Provide a test for the ramp boost feature as posted on LKML.
This test will mostly catch cases where schedutil is not called as often as
expected, since it reads most of the signals from the kernel instead of guessing
them.