Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rk3399: licensing of hdcp.bin #651

Open
vagrantc opened this issue Nov 25, 2018 · 4 comments
Open

rk3399: licensing of hdcp.bin #651

vagrantc opened this issue Nov 25, 2018 · 4 comments
Labels

Comments

@vagrantc
Copy link

The file plat/rockchip/rk3399/drivers/dp/hdcp.bin is a binary without source.

In the commit it was introduced, it suggests it is not open source:

commit c76631c52b0b1550ff182c177555485700274314
Author: Ziyuan Xu xzy.xu@rock-chips.com
Date: Thu Oct 27 19:07:35 2016 +0800

rockchip: include hdcp.bin and declare hdcp key decryption handler                                         

For some reason, HDCP key decrytion can't open source in ATF, so we                                        
build it as hdcp.bin. Besides declare the handler for decrypting.

Change-Id: Ia67ff2442ab43cb3ee4875b3d59cc1608e854b4b                                                       
Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com>
Signed-off-by: Caesar Wang <wxt@rock-chips.com>

Is it possible to get additional clarity on the licensing of this file? If not possible, would it be possible or meaningful to have a variant build without this binary included? Many free software distributions, such as Debian, require building from source in order to be allowed in the distribution.

Thanks!

@ghost
Copy link

ghost commented Nov 26, 2018

@rockchip-linux

@ghost ghost added the question label Nov 26, 2018
@jwerner-chromium
Copy link

I'll leave the license question to Rockchip, but it should be pretty easy to add a compile-time option to optionally exclude this binary. It is only needed for HDCP support (a DRM feature for video streaming), if you don't care about that the rest of the firmware should work perfectly fine without it. Just change rk3399/plat_sip_calls.c to not handle the RK_SIP_HDCP* SMCs when this option is set, and then exclude rk3399/drivers/dp/cdn_dp.c and the blob from rk3399/platform.mk.

@arm-tf-bot
Copy link

Hello @vagrantc!

Thank you for raising an issue for Trusted Firmware-A.

The TF-A project has now migrated to www.trustedfirmware.org. This issue tracker will still remain accessible for some time, but only for historical reasons. From now on you should raise any new issues on trustedfirmware.org.

How do I raise issues for TF-A?

Please use our new issue tracking board. For this you just need to login with your existing GitHub account. We also have a guide to help you raise the issue with the appropriate labels and tags. This way it will be easier for both you and us to track and address the issue most effectively.

What if I face any problems?

You can send us an email in the public TF-A mailing list. Here you can also find all the mailing lists for all the projects hosted under trustedfirmware.org.

We are looking forward to seeing you in trustedfirmware.org!

The Trusted Firmware-A team

1 similar comment
@ssg-bot
Copy link

ssg-bot commented Oct 18, 2019

Hello @vagrantc!

Thank you for raising an issue for Trusted Firmware-A.

The TF-A project has now migrated to www.trustedfirmware.org. This issue tracker will still remain accessible for some time, but only for historical reasons. From now on you should raise any new issues on trustedfirmware.org.

How do I raise issues for TF-A?

Please use our new issue tracking board. For this you just need to login with your existing GitHub account. We also have a guide to help you raise the issue with the appropriate labels and tags. This way it will be easier for both you and us to track and address the issue most effectively.

What if I face any problems?

You can send us an email in the public TF-A mailing list. Here you can also find all the mailing lists for all the projects hosted under trustedfirmware.org.

We are looking forward to seeing you in trustedfirmware.org!

The Trusted Firmware-A team

thefallenidealist added a commit to thefallenidealist/atf that referenced this issue Aug 14, 2021
Remove code which is not usable without hdcp.bin file

ARM-software/tf-issues#651
It is only needed for HDCP support (a DRM feature for video streaming),
if you don't care about that the rest of the firmware should work
perfectly fine without it. Just change rk3399/plat_sip_calls.c to not
handle the RK_SIP_HDCP* SMCs when this option is set, and then exclude
rk3399/drivers/dp/cdn_dp.c and the blob from rk3399/platform.mk.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants