Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TESTS: skip timing accuracy test on FastModels #10030

Merged
merged 1 commit into from Mar 28, 2019

Conversation

Projects
None yet
6 participants
@jamesbeyond
Copy link
Contributor

commented Mar 11, 2019

Description

This is the test case for timing accuracy, Software models can't guarantee it's time accuracy as it's nature.
So skip this test for FastModels.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change
@@ -23,6 +23,11 @@
#include "hal/us_ticker_api.h"
#include "hal/lp_ticker_api.h"

//FastModels not support timing test
#if defined(__ARM_FM)

This comment has been minimized.

Copy link
@jeromecoutant

jeromecoutant Mar 11, 2019

Contributor

I thought that specifying a specific target in tests was not recommended ?

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Mar 11, 2019

Member

Correct is not. This is however an architecture exclusion

@ARMmbed/mbed-os-hal Please review

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Mar 11, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

@0xc0170 0xc0170 removed the request for review from ARMmbed/mbed-os-test Mar 11, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

Similar reasoning to #10124 (comment)

@cmonr

cmonr approved these changes Mar 27, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 28, 2019

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

Will restart jenkins-ci/greentea-test when able.

The failures were all related to K66F timeouts.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

CI job restarted: jenkins-ci/greentea-test

K66F failures shouldn't be related to this PR.

@cmonr cmonr merged commit 8e819de into ARMmbed:master Mar 28, 2019

21 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/greentea-test Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9971 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.