Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TESTS: skip timing accuracy test on FastModels #10030

Merged
merged 1 commit into from
Mar 28, 2019
Merged

TESTS: skip timing accuracy test on FastModels #10030

merged 1 commit into from
Mar 28, 2019

Conversation

jamesbeyond
Copy link
Contributor

@jamesbeyond jamesbeyond commented Mar 11, 2019 •
edited by cmonr
Loading

Description

This is the test case for timing accuracy, Software models can't guarantee it's time accuracy as it's nature.
So skip this test for FastModels.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

jeromecoutant
jeromecoutant reviewed Mar 11, 2019
View reviewed changes
TESTS/mbed_platform/wait_ns/main.cpp
@@ -23,6 +23,11 @@
#include "hal/us_ticker_api.h"
#include "hal/lp_ticker_api.h"

//FastModels not support timing test
#if defined(__ARM_FM)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that specifying a specific target in tests was not recommended ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct is not. This is however an architecture exclusion

@ARMmbed/mbed-os-hal Please review

@ciarmcom ciarmcom requested review from a team March 11, 2019 12:00
@ciarmcom
Copy link
Member

@jamesbeyond, thank you for your changes.
@ARMmbed/mbed-os-test @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 removed the request for review from a team March 11, 2019 12:15
@jamesbeyond jamesbeyond mentioned this pull request Mar 15, 2019
Merged
@cmonr
Copy link
Contributor

cmonr commented Mar 27, 2019

Similar reasoning to #10124 (comment)

@cmonr
Copy link
Contributor

cmonr commented Mar 27, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 28, 2019

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@cmonr
Copy link
Contributor

cmonr commented Mar 28, 2019

Will restart jenkins-ci/greentea-test when able.

The failures were all related to K66F timeouts.

@cmonr
Copy link
Contributor

cmonr commented Mar 28, 2019

CI job restarted: jenkins-ci/greentea-test

K66F failures shouldn't be related to this PR.

@cmonr cmonr merged commit 8e819de into ARMmbed:master Mar 28, 2019
@cmonr cmonr removed the needs: CI label Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 left review comments

@jeromecoutant jeromecoutant jeromecoutant left review comments

@cmonr cmonr cmonr approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jamesbeyond @ciarmcom @cmonr @mbed-ci @0xc0170 @jeromecoutant