Enable low-power ticker and Sleep for FastModels #10124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,9 +74,10 @@ Case cases[] = { | |||
| Case("1 s delay during deepsleep (attach_us)", test_deepsleep<AttachUSTester<LowPowerTimeout>, 1000000, LONG_DELTA_US>, | |||
| greentea_failure_handler), | |||
| #endif | |||
|
|
|||
| #if !defined(__ARM_FM) //FastModels not support time drifting test | |||
There was a problem hiding this comment.
Is it OK to remove some tests because they are not passing....?
There was a problem hiding this comment.
Not sure how is it not supported?
@ARMmbed/mbed-os-hal to review
There was a problem hiding this comment.
It is same story as #10030
For partner's targets/platforms, which will be used real life production. we are not allow them to skip tests, if they can't make them pass. The tests are mean to check that all platform comply with mbed HAL API.
FastModel it is a software simulator for Arm platform/cores. mean to be used as a tool for testing or early stage development. It is will never be used for any real IoT products.
They can simulator how ARM core works. One of issue for software simulator is they running on your host PC, they can't grantee the timing accuracy as microelectronics.
So the exception is just for the software models
|
@jamesbeyond, thank you for your changes. |
|
Attched the GreenTea test results: |
|
@jamesbeyond I really liked the response for why the test is being skipped for this target (#10124 (comment)) Would you mind ammending the commit that adds that line so that the commit history has that information? |
added 5 commits
April 3, 2019 16:37
- reanme US_TICKER_TIMER1 to US_TICKER_COUNTER - reanme US_TICKER_TIMER2 to US_TICKER_INTERRUPT
FastModels are a software simulator for Arm platform/cores. They mean to be used as a tool for testing or early prototype stage development. Due to the nature of software simulator can't grantee the timing accuracy like HW. So time drifting test is skipped for software models.
OPpuolitaival
approved these changes
Apr 4, 2019
0xc0170
requested changes
Apr 4, 2019
|
@0xc0170 |
0xc0170
approved these changes
Apr 8, 2019
|
CI started |
Test run: FAILEDSummary: 1 of 13 test jobs failed Failed test jobs:
|
|
Checking the failed exporter test, it failed at |
|
CI job restarted: ARMc6 license issue. |
0xc0170
added
release-version: 5.12.2
ready for merge
and removed
release-version: 5.12.1
needs: CI
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enabled low-power ticker and Sleep HAL API for FastModels.
with enabling of low-power and Sleep API would allow FastModels run more greentea tests.
Pull request type