Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: call AT+CGEREP after sim is ready #10081

Merged
merged 1 commit into from Mar 18, 2019

Conversation

Projects
None yet
7 participants
@jarvte
Copy link
Contributor

commented Mar 13, 2019

Description

Current implementation did call AT+CGEREP before sim was ready and it was failing in most modems.
Now call is made after sim is ready.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AriParkkila

Release Notes

AT+CGEREP call was made before sim was ready and it was failing in most modems.
Now call is made after sim is ready.

@ciarmcom ciarmcom requested review from AriParkkila and ARMmbed/mbed-os-maintainers Mar 13, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

@jarvte, thank you for your changes.
@AriParkkila @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 added needs: work and removed needs: review labels Mar 14, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

Needs rebase now

@jarvte jarvte force-pushed the jarvte:move_call_CGEREP branch Mar 15, 2019

@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2019

@0xc0170 rebase done

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

@jarvte Sorry, looks like another rebase is needed.

@cmonr cmonr added needs: work and removed needs: CI labels Mar 15, 2019

Cellular: call AT+CGEREP after sim is ready
Current implementation did call AT+CGEREP before sim was ready
and it was failing in most modems.

@jarvte jarvte force-pushed the jarvte:move_call_CGEREP branch to dba3d42 Mar 18, 2019

@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

@0xc0170 rebase done, also fix for astyle after rebase, hence the force push

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Mar 18, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

Ci started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 18, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 18, 2019

@0xc0170 0xc0170 merged commit 6b84b14 into ARMmbed:master Mar 18, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9147 cycles (-759 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@jarvte jarvte deleted the jarvte:move_call_CGEREP branch Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.