Cellular: call AT+CGEREP after sim is ready #10081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriParkkila
approved these changes
Mar 13, 2019
|
@jarvte, thank you for your changes. |
AriParkkila
approved these changes
Mar 14, 2019
AnttiKauppila
approved these changes
Mar 14, 2019
0xc0170
approved these changes
Mar 14, 2019
|
Needs rebase now |
jarvte
force-pushed
the
move_call_CGEREP
branch
from
4d8a1b7
to
7f9a488
Compare
|
@0xc0170 rebase done |
|
@jarvte Sorry, looks like another rebase is needed. |
Current implementation did call AT+CGEREP before sim was ready and it was failing in most modems.
jarvte
force-pushed
the
move_call_CGEREP
branch
from
7f9a488
to
dba3d42
Compare
|
@0xc0170 rebase done, also fix for astyle after rebase, hence the force push |
|
Ci started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current implementation did call AT+CGEREP before sim was ready and it was failing in most modems.
Now call is made after sim is ready.
Pull request type
Reviewers
@AriParkkila
Release Notes
AT+CGEREP call was made before sim was ready and it was failing in most modems.
Now call is made after sim is ready.