Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPC55S69_S: reduce ITS size to 32KB #10101

Merged
merged 2 commits into from
Mar 14, 2019
Merged

LPC55S69_S: reduce ITS size to 32KB #10101

merged 2 commits into from
Mar 14, 2019

Conversation

mikisch81
Copy link
Contributor

@mikisch81 mikisch81 commented Mar 14, 2019 •
edited
Loading

Description

As there is no use-case for more than a few keys saved in the Secure ITS (Pelion client stores most of its' keys in NS storage), there is no need for dual 32KB ITS, so reducing it by half.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@davidsaada @mmahadevan108

Release Notes

@mikisch81
Copy link
Contributor Author

@jenia81 @mottigondabi FYI
This will enable NS app to be as much as 416KB.

@NirSonnenschein
Copy link
Contributor

Note: this change is very important for client integration as the non-secure side was too small for building the client with debug prints.

LPC55S69_S: reduce ITS size to 32KB
dca3ebe 
- Reduce LPC55S69 secure side ITS from 64KB to 32KB
@mmahadevan108
Copy link
Contributor

@mikisch81 . Please help update
https://github.com/ARMmbed/mbed-os/blob/master/targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_LPC55S69/TARGET_M33_NS/device/TOOLCHAIN_IAR/LPC55S69_cm33_core0_flash.icf#L26

@mikisch81
Copy link
Contributor Author

@mikisch81 . Please help update
https://github.com/ARMmbed/mbed-os/blob/master/targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_LPC55S69/TARGET_M33_NS/device/TOOLCHAIN_IAR/LPC55S69_cm33_core0_flash.icf#L26

Done

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 14, 2019

Ci started

@mikisch81
Copy link
Contributor Author

PSA tests results on LPC55S69:

| target            | platform_name | test suite                                                           | result      | elapsed_time (sec) | copy_method |
|-------------------|---------------|----------------------------------------------------------------------|-------------|--------------------|-------------|
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_attestation-test_a001 | OK          | 32.02              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c001      | OK          | 17.16              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c002      | OK          | 17.88              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c003      | OK          | 17.79              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c004      | OK          | 17.81              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c005      | OK          | 17.59              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c006      | OK          | 17.79              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c007      | OK          | 17.74              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c008      | OK          | 17.67              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c009      | OK          | 17.23              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c010      | OK          | 17.46              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c011      | OK          | 17.08              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c012      | OK          | 17.31              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c013      | OK          | 17.24              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c014      | OK          | 17.31              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c015      | OK          | 17.17              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c016      | OK          | 17.53              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c017      | OK          | 17.49              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c018      | OK          | 17.06              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c019      | OK          | 17.09              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c020      | OK          | 17.47              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c021      | OK          | 17.05              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c022      | OK          | 17.63              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c023      | OK          | 17.25              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c024      | OK          | 17.62              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c025      | OK          | 17.74              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c026      | OK          | 17.6               | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c027      | OK          | 17.26              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c028      | OK          | 17.17              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c029      | OK          | 17.71              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c030      | OK          | 17.21              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c031      | OK          | 17.15              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c032      | OK          | 17.95              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c033      | OK          | 17.91              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c034      | OK          | 17.19              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c035      | OK          | 17.21              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c036      | OK          | 17.64              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c037      | OK          | 17.84              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c038      | OK          | 17.38              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c039      | OK          | 18.34              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c040      | OK          | 19.89              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c041      | OK          | 19.47              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c042      | OK          | 19.91              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_crypto-test_c043      | OK          | 21.55              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_its-test_s001         | OK          | 17.44              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_its-test_s002         | OK          | 17.44              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_its-test_s004         | OK          | 16.99              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_its-test_s005         | OK          | 16.96              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_its-test_s006         | OK          | 16.96              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_its-test_s007         | OK          | 17.14              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_its-test_s008         | OK          | 17.06              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_its-test_s009         | OK          | 17.33              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-components-target_psa-tests-compliance_its-test_s010         | OK          | 16.95              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-tests-mbed-crypto-sanity                                     | OK          | 19.81              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-tests-psa-attestation                                        | OK          | 20.02              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-tests-psa-crypto_access_control                              | SYNC_FAILED | 40.93              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-tests-psa-crypto_init                                        | OK          | 17.22              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-tests-psa-entropy_inject                                     | OK          | 18.24              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-tests-psa-its_ps                                             | OK          | 18.64              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-tests-psa-spm_client                                         | OK          | 22.7               | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-tests-psa-spm_server                                         | OK          | 20.26              | default     |
| LPC55S69_NS-ARMC6 | LPC55S69      | mbed-os-tests-psa-spm_smoke                                          | OK          | 16.85              | default     |
mbedgt: test suite results: 1 SYNC_FAILED / 61 OK

@ARMmbed/mbed-os-maintainers please hold this PR for now until we check what is wrong with failing mbed-os-tests-psa-crypto_access_control tests

davidsaada
davidsaada approved these changes Mar 14, 2019
View reviewed changes
Copy link
Contributor

@davidsaada davidsaada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK (besides the fact I need to change #10086 to fit these changes again).

@NirSonnenschein
Copy link
Contributor

checking regarding issue with mbed-os-tests-psa-crypto_access_control before we can this forward

@NirSonnenschein
Copy link
Contributor

subsequent re-test with updated binaries was successful.
stopping then restarting CI

@davidsaada davidsaada mentioned this pull request Mar 14, 2019
Merged
@mbed-ci
Copy link

mbed-ci commented Mar 14, 2019

Test run: FAILED

Summary: 4 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_greentea-test
  • jenkins-ci/mbed-os-ci_exporter

@alekshex
Copy link
Contributor

the psa crypto access control test passes:

mbedgt: processing target 'LPC55S69' toolchain 'ARMC6' compatible platforms... (note: switch set to --parallel 1)
mbedgt: test case filter (specified with -n option)
access
test filtered in 'tests-psa-crypto_access_control'
test filtered in 'features-storage-tests-kvstore-direct_access_devicekey_test'
mbedgt: running 2 tests for platform 'LPC55S69' and toolchain 'ARMC6'
mbedgt: mbed-host-test-runner: started
mbedgt: checking for GCOV data...
mbedgt: test on hardware with target id: 0236000002868cf300000000000000000000000097969905
mbedgt: test suite 'tests-psa-crypto_access_control' ................................................. OK in 20.54 sec
test case: 'create key with same id different partitions' .................................... OK in 0.09 sec
test case: 'open other partitions' key' ...................................................... OK in 0.06 sec
test case: 'use other partitions' key - aead' ................................................ OK in 0.07 sec
test case: 'use other partitions' key - asymmetric encrypt decrypt' .......................... OK in 0.13 sec
test case: 'use other partitions' key - asymmetric sign verify' .............................. OK in 0.91 sec
test case: 'use other partitions' key - cipher' .............................................. OK in 0.07 sec
test case: 'use other partitions' key - key manage' .......................................... OK in 0.09 sec
test case: 'use other partitions' key - mac' ................................................. OK in 0.07 sec

@mbed-ci
Copy link

mbed-ci commented Mar 14, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr merged commit d53ff0b into ARMmbed:master Mar 14, 2019
@cmonr cmonr removed the needs: CI label Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@NirSonnenschein NirSonnenschein NirSonnenschein approved these changes

@mmahadevan108 mmahadevan108 mmahadevan108 approved these changes

@orenc17 orenc17 orenc17 approved these changes

@davidsaada davidsaada davidsaada approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.0-rc3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@mikisch81 @NirSonnenschein @mmahadevan108 @0xc0170 @mbed-ci @alekshex @orenc17 @davidsaada @cmonr