Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bootloader support for the LPC55S69 board #10086

Merged
merged 1 commit into from Mar 16, 2019

Conversation

Projects
None yet
9 participants
@davidsaada
Copy link
Contributor

commented Mar 13, 2019

Description

This PR adds bootloader support for the LPC55S69 board.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@0xc0170 0xc0170 requested review from mmahadevan108, mikisch81 and ARMmbed/mbed-os-psa Mar 13, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

5.12.0-rc3 - is that correct?

tools/arm_pack_manager/index.json Outdated
"size": "0x58000"
}
}
},

This comment has been minimized.

Copy link
@mmahadevan108

mmahadevan108 Mar 13, 2019

Contributor

We have PR 10068 for this, can you please remove this section

This comment has been minimized.

Copy link
@davidsaada

davidsaada Mar 14, 2019

Author Contributor

@mmahadevan108 AFAIK #10068 is not destined for 5.12, while this one is, so I can't have this PR depend on it.

This comment has been minimized.

Copy link
@mikisch81

mikisch81 Mar 14, 2019

Contributor

@david, is the index.json here same as in #10068?
@mmahadevan108 as this PR more urgent for rc3, is it possible to make #10068 dependent on this PR?

This comment has been minimized.

Copy link
@davidsaada

davidsaada Mar 14, 2019

Author Contributor

Not the same. I can make it the same (which is the largest part of that PR).

This comment has been minimized.

Copy link
@mikisch81

mikisch81 Mar 14, 2019

Contributor

@davidsaada @mmahadevan108 Then I suggest you sync with each other

This comment has been minimized.

Copy link
@mmahadevan108

mmahadevan108 Mar 14, 2019

Contributor

Please delete this change from this PR.

This comment has been minimized.

Copy link
@davidsaada

davidsaada Mar 14, 2019

Author Contributor

@mmahadevan108 This certainly needs to be deleted. However, as I explained below, our tools won't build the bootloader well without this change. This should currently be on hold until resolved.

This comment has been minimized.

Copy link
@mmahadevan108

mmahadevan108 Mar 14, 2019

Contributor

👍 . Would you like to try with the changes from #10068 to ensure it works fine with the tools.

This comment has been minimized.

Copy link
@davidsaada

davidsaada Mar 14, 2019

Author Contributor

Sorry if I wasn't clear - this requires a change in the bootloader build tools, by which index.json should be ignored in such cases. Until then, this PR will fail if we use the values from #10068. In other words, this PR should be on hold until these tools changes are introduced.

This comment has been minimized.

Copy link
@mmahadevan108

mmahadevan108 Mar 14, 2019

Contributor

👍 , got it.

@orenc17

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

needs to be rebased on top of #10047

@davidsaada davidsaada force-pushed the davidsaada:david_lpc55s69_bootloader branch 2 times, most recently Mar 13, 2019

@davidsaada davidsaada force-pushed the davidsaada:david_lpc55s69_bootloader branch Mar 13, 2019

@davidsaada

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2019

Please disregard my force pushes for the time being. Having some hard time with this rebase. Will update when done.

@davidsaada davidsaada force-pushed the davidsaada:david_lpc55s69_bootloader branch Mar 13, 2019

"*": {
"target.app_offset": "0x8400",
"target.header_offset": "0x8000",
"target.bootloader_img": "mbed-bootloader-lpc55s69-v1_0_0.hex"

This comment has been minimized.

Copy link
@mmahadevan108

mmahadevan108 Mar 13, 2019

Contributor

What does this bootloader do?

This comment has been minimized.

Copy link
@0xc0170

@davidsaada davidsaada force-pushed the davidsaada:david_lpc55s69_bootloader branch Mar 13, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

I think this can be rebased when able.

@dannybenor

This comment has been minimized.

Copy link

commented Mar 14, 2019

@mmahadevan108 This is the Pelion firmware update bootloader. Is able to verify and retrieve a downloaded image from external storage into rom and replace current application with the new one. All this is happening in the NSPE.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

I think this can be rebased when able.

@davidsaada already rebased, ready for review?

@davidsaada

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

I think this can be rebased when able.

@davidsaada already rebased, ready for review?

Not yet. Got a small issue I need to resolve. Will update.

@davidsaada davidsaada force-pushed the davidsaada:david_lpc55s69_bootloader branch 3 times, most recently Mar 14, 2019

@davidsaada

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

Rebased on top of master. Sorry for the noise.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Mar 14, 2019

@davidsaada

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2019

Thanks @cmonr, will rebase. However, this PR should be on hold until tools team introduce a solution to the index.json problem, hopefully by the end of the day.

Is there tracking issue for this?

No.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

Thanks @cmonr, will rebase. However, this PR should be on hold until tools team introduce a solution to the index.json problem, hopefully by the end of the day.

@ARMmbed/mbed-os-tools has this been addressed or in progress?

@bridadan

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

@0xc0170 I believe so in this PR: #10113

@davidsaada davidsaada force-pushed the davidsaada:david_lpc55s69_bootloader branch Mar 15, 2019

@davidsaada

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2019

Rebased on top of master. However, taking the changes from #10113 doesn't work.
Will work with @bridadan and @theotherjimmy offline to tackle these problems in order not to contaminate this thread.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

Will work with @bridadan and @theotherjimmy offline to tackle these problems in order not to contaminate this thread.

Please do. #10113 was integrated

@davidsaada davidsaada force-pushed the davidsaada:david_lpc55s69_bootloader branch Mar 15, 2019

@davidsaada

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2019

OK, it appears that the mistake was mine - used a wrong configuration option when building the application with the bootloader. Thanks @theotherjimmy for the help here.
Rebased with master now and everything seems to work fine. OK to proceed from my POV.

@davidsaada davidsaada force-pushed the davidsaada:david_lpc55s69_bootloader branch Mar 15, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

@davidsaada Thanks for the update fixing Travis CI pytest 😉

@davidsaada davidsaada force-pushed the davidsaada:david_lpc55s69_bootloader branch to eb5cef8 Mar 15, 2019

@davidsaada

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2019

Sorry, old index.json slipped in. Fixed now.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

Will restart CI once Travis completes.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Mar 16, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 16, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Mar 16, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr

cmonr approved these changes Mar 16, 2019

@cmonr cmonr merged commit e901dfa into ARMmbed:master Mar 16, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9069 cycles (-1285 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Mar 16, 2019

@orenc17

This comment has been minimized.

Copy link
Contributor

commented Mar 16, 2019

@cmonr

Genesis 2:2-3 New King James Version (NKJV)
2 And on the seventh day God ended His work which He had done, and He rested on the seventh day from all His work which He had done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.