Add bootloader support for the LPC55S69 board #10086

davidsaada · 2019-03-13T15:11:53Z

Description

This PR adds bootloader support for the LPC55S69 board.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

0xc0170 · 2019-03-13T15:29:28Z

5.12.0-rc3 - is that correct?

mmahadevan108 · 2019-03-13T15:36:06Z

tools/arm_pack_manager/index.json

+            "size": "0x58000"
+        }
+      }
+    },


We have PR 10068 for this, can you please remove this section

@mmahadevan108 AFAIK #10068 is not destined for 5.12, while this one is, so I can't have this PR depend on it.

@david, is the index.json here same as in #10068?
@mmahadevan108 as this PR more urgent for rc3, is it possible to make #10068 dependent on this PR?

Not the same. I can make it the same (which is the largest part of that PR).

@davidsaada @mmahadevan108 Then I suggest you sync with each other

Please delete this change from this PR.

@mmahadevan108 This certainly needs to be deleted. However, as I explained below, our tools won't build the bootloader well without this change. This should currently be on hold until resolved.

👍 . Would you like to try with the changes from #10068 to ensure it works fine with the tools.

Sorry if I wasn't clear - this requires a change in the bootloader build tools, by which index.json should be ignored in such cases. Until then, this PR will fail if we use the values from #10068. In other words, this PR should be on hold until these tools changes are introduced.

👍 , got it.

orenc17 · 2019-03-13T15:36:29Z

needs to be rebased on top of #10047

davidsaada · 2019-03-13T16:28:43Z

Please disregard my force pushes for the time being. Having some hard time with this rebase. Will update when done.

mmahadevan108 · 2019-03-13T16:34:33Z

...s/FEATURE_BOOTLOADER/targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_LPC55S69/mbed_lib.json

+        "*": {
+            "target.app_offset": "0x8400",
+            "target.header_offset": "0x8000",
+            "target.bootloader_img": "mbed-bootloader-lpc55s69-v1_0_0.hex"


What does this bootloader do?

Please see https://os.mbed.com/docs/mbed-os/v5.11/tutorials/bootloader.html (Prebuilt bootloaders section)

cmonr · 2019-03-13T23:21:44Z

I think this can be rebased when able.

dannybenor · 2019-03-14T08:06:33Z

@mmahadevan108 This is the Pelion firmware update bootloader. Is able to verify and retrieve a downloaded image from external storage into rom and replace current application with the new one. All this is happening in the NSPE.

0xc0170 · 2019-03-14T09:28:10Z

I think this can be rebased when able.

@davidsaada already rebased, ready for review?

davidsaada · 2019-03-14T09:30:13Z

I think this can be rebased when able.

@davidsaada already rebased, ready for review?

Not yet. Got a small issue I need to resolve. Will update.

davidsaada · 2019-03-14T10:48:55Z

Rebased on top of master. Sorry for the noise.

0xc0170 · 2019-03-15T07:07:04Z

Thanks @cmonr, will rebase. However, this PR should be on hold until tools team introduce a solution to the index.json problem, hopefully by the end of the day.

Is there tracking issue for this?

davidsaada · 2019-03-15T07:09:32Z

Thanks @cmonr, will rebase. However, this PR should be on hold until tools team introduce a solution to the index.json problem, hopefully by the end of the day.

Is there tracking issue for this?

No.

0xc0170 · 2019-03-15T15:20:37Z

Thanks @cmonr, will rebase. However, this PR should be on hold until tools team introduce a solution to the index.json problem, hopefully by the end of the day.

@ARMmbed/mbed-os-tools has this been addressed or in progress?

bridadan · 2019-03-15T15:23:28Z

@0xc0170 I believe so in this PR: #10113

davidsaada · 2019-03-15T19:12:48Z

Rebased on top of master. However, taking the changes from #10113 doesn't work.
Will work with @bridadan and @theotherjimmy offline to tackle these problems in order not to contaminate this thread.

0xc0170 · 2019-03-15T20:21:11Z

Will work with @bridadan and @theotherjimmy offline to tackle these problems in order not to contaminate this thread.

Please do. #10113 was integrated

davidsaada · 2019-03-15T22:04:27Z

OK, it appears that the mistake was mine - used a wrong configuration option when building the application with the bootloader. Thanks @theotherjimmy for the help here.
Rebased with master now and everything seems to work fine. OK to proceed from my POV.

cmonr · 2019-03-15T22:10:32Z

@davidsaada Thanks for the update fixing Travis CI pytest 😉

bla

davidsaada · 2019-03-15T22:15:11Z

Sorry, old index.json slipped in. Fixed now.

cmonr · 2019-03-15T22:16:04Z

Will restart CI once Travis completes.

0xc0170 · 2019-03-16T05:25:21Z

CI started

mbed-ci · 2019-03-16T08:22:52Z

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

orenc17 · 2019-03-16T14:34:11Z

@cmonr

Genesis 2:2-3 New King James Version (NKJV)
2 And on the seventh day God ended His work which He had done, and He rested on the seventh day from all His work which He had done.

0xc0170 requested review from mmahadevan108, mikisch81 and a team March 13, 2019 15:29

0xc0170 added needs: review release-version: 5.12.0-rc3 labels Mar 13, 2019

mmahadevan108 reviewed Mar 13, 2019

View reviewed changes

0xc0170 added the needs: preceding PR label Mar 13, 2019

davidsaada force-pushed the david_lpc55s69_bootloader branch 2 times, most recently from 986c20a to ffd64d1 Compare March 13, 2019 16:00

orenc17 mentioned this pull request Mar 13, 2019

Reduce 32KB from LPC55S69_S binary size #10047

Merged

davidsaada force-pushed the david_lpc55s69_bootloader branch from ffd64d1 to 25b8267 Compare March 13, 2019 16:24

davidsaada force-pushed the david_lpc55s69_bootloader branch from 25b8267 to b9b2050 Compare March 13, 2019 16:29

mmahadevan108 reviewed Mar 13, 2019

View reviewed changes

davidsaada force-pushed the david_lpc55s69_bootloader branch from b9b2050 to 5b1715f Compare March 13, 2019 18:53

cmonr added needs: work and removed needs: preceding PR needs: review labels Mar 14, 2019

davidsaada force-pushed the david_lpc55s69_bootloader branch 3 times, most recently from a5ccb96 to 7e1e983 Compare March 14, 2019 10:44

0xc0170 added needs: CI and removed needs: work labels Mar 14, 2019

cmonr added needs: CI needs: preceding PR and removed needs: work labels Mar 15, 2019

davidsaada force-pushed the david_lpc55s69_bootloader branch from efa4f5f to 7bfdf30 Compare March 15, 2019 19:10

0xc0170 added needs: work and removed needs: CI needs: preceding PR labels Mar 15, 2019

davidsaada force-pushed the david_lpc55s69_bootloader branch from 7bfdf30 to 9ac262e Compare March 15, 2019 22:01

davidsaada force-pushed the david_lpc55s69_bootloader branch from 9ac262e to 8d32064 Compare March 15, 2019 22:09

Add bootloader support for the LPC55S69 board

eb5cef8

bla

davidsaada force-pushed the david_lpc55s69_bootloader branch from 8d32064 to eb5cef8 Compare March 15, 2019 22:13

orenc17 approved these changes Mar 15, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Mar 16, 2019

cmonr approved these changes Mar 16, 2019

View reviewed changes

cmonr merged commit e901dfa into ARMmbed:master Mar 16, 2019

cmonr removed the needs: CI label Mar 16, 2019

Add bootloader support for the LPC55S69 board #10086

Add bootloader support for the LPC55S69 board #10086

Uh oh!

Conversation

davidsaada commented Mar 13, 2019

Description

Pull request type

Reviewers

Release Notes

Uh oh!

0xc0170 commented Mar 13, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

orenc17 commented Mar 13, 2019

Uh oh!

davidsaada commented Mar 13, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmonr commented Mar 13, 2019

Uh oh!

dannybenor commented Mar 14, 2019

Uh oh!

0xc0170 commented Mar 14, 2019

Uh oh!

davidsaada commented Mar 14, 2019

Uh oh!

davidsaada commented Mar 14, 2019

Uh oh!

0xc0170 commented Mar 15, 2019

Uh oh!

davidsaada commented Mar 15, 2019

Uh oh!

0xc0170 commented Mar 15, 2019

Uh oh!

bridadan commented Mar 15, 2019

Uh oh!

davidsaada commented Mar 15, 2019

Uh oh!

0xc0170 commented Mar 15, 2019

Uh oh!

davidsaada commented Mar 15, 2019

Uh oh!

cmonr commented Mar 15, 2019

Uh oh!

davidsaada commented Mar 15, 2019

Uh oh!

cmonr commented Mar 15, 2019

Uh oh!

0xc0170 commented Mar 16, 2019

Uh oh!

mbed-ci commented Mar 16, 2019

Uh oh!

orenc17 commented Mar 16, 2019

Uh oh!

Uh oh!