Fix QSPIF Bus mode mask and quad enable write SR size #10171

offirko · 2019-03-20T12:32:30Z

Fix Bus mode mask, and fix status register write size in some quad enable modes

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

some modes in quad enable

offirko · 2019-03-20T12:37:21Z

@ARMmbed/mbed-os-maintainers , @ARMmbed/mbed-os-storage , @VairaRamasamy - please review.

offirko · 2019-03-20T12:38:19Z

@VairaRamasamy - can you please test the fix on CY8CPROTO_062_4343W

0xc0170 · 2019-03-20T12:39:50Z

components/storage/blockdevice/COMPONENT_QSPIF/QSPIFBlockDevice.cpp

@@ -874,6 +875,7 @@ int QSPIFBlockDevice::_sfdp_set_quad_enabled(uint8_t *basic_param_table_ptr)
            status_reg_setup[1] = 0x2; // Bit 1 of status Reg 2
            _read_register_inst = 0x35;
            sr_read_size = 1;
+	    sr_write_size = 2;


seems to be misaligned (astyle should catch these)

sorry fixing

0xc0170 · 2019-03-20T12:40:32Z

components/storage/blockdevice/COMPONENT_QSPIF/QSPIFBlockDevice.cpp

@@ -1032,7 +1034,7 @@ int QSPIFBlockDevice::_sfdp_detect_best_bus_read_mode(uint8_t *basic_param_table
        }
        is_qpi_mode = false;
        examined_byte = basic_param_table_ptr[QSPIF_BASIC_PARAM_TABLE_FAST_READ_SUPPORT_BYTE];
-        if (examined_byte & 0x40) {
+        if (examined_byte & 0x20) {


how is this mode fix related to sr_write_size - they are both in the same commit - should they be in separate commits ?

Its two small changes, both are related to quad enabling process... though they in different areas. I can separate them if required.

Could be fine, what about commit message (issues have details for these fixes to be tter understand them) ?

vi · 2019-03-20T12:42:12Z

@vi ... - please review

Maybe meant "@vimalrajr"?

When setting Quad Enable, either SR1, SR2 or CR setup is required. Either way register size is up to 2 bytes.

ciarmcom · 2019-03-20T14:00:38Z

@offirko, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

components/storage/blockdevice/COMPONENT_QSPIF/QSPIFBlockDevice.cpp

cy-vaira

@VairaRamasamy - can you please test the fix on CY8CPROTO_062_4343W

@offirko I've tested this on CY8CPROTO_062_4343W and it works! Thanks for the fix.

yossi2le

I would consider adding a return in the default section of the case.
Other than that, it looks good to me.

offirko · 2019-03-28T08:22:36Z

@yossi2le - thanks, I fixed default "Unsupported" behavior to do nothing but log warning and return.

cmonr · 2019-03-28T22:17:19Z

CI started

mbed-ci · 2019-03-29T05:46:27Z

Test run: FAILED

Summary: 2 of 9 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARMC6
jenkins-ci/mbed-os-ci_build-GCC_ARM

adbridge · 2019-03-29T13:53:03Z

@offirko please take a look at the failures

cmonr · 2019-03-29T18:38:33Z

CI started

mbed-ci · 2019-03-29T21:44:57Z

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

offirko · 2019-03-31T07:09:31Z

@NirSonnenschein - failures are on K66F that wasnt available: "[1553892247.32][CONN][ERR] Failed to connect to resource" , can you please rerun CI

NirSonnenschein · 2019-03-31T07:10:48Z

restarted CI

mbed-ci · 2019-03-31T09:09:14Z

Test run: FAILED

Summary: 1 of 13 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

offirko · 2019-03-31T09:13:50Z

@NirSonnenschein - hmm same K66F availability issue..
[1554020328.12][GLRM][ERR] Flash response(request_id: 9bc74b62-538d-11e9-8bc0-0242ac110008) failed with message: Resource is not connected

mbed-ci · 2019-04-01T09:15:43Z

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 4
Build artifacts

0xc0170 · 2019-04-01T09:16:25Z

@NirSonnenschein - hmm same K66F availability issue..

Few targets went offline, fixed today

…o/offir_qspi_bus_mask_fix

Fix Bus mode mask and status register write size in

ce5194f

some modes in quad enable

This was referenced Mar 20, 2019

QSPIFBlockDevice: status register write size cannot have a fixed value #10165

Closed

QSPIFBlockDevice: SFDP bus mode parser uses wrong mask values #10163

Closed

0xc0170 reviewed Mar 20, 2019

View reviewed changes

Fixed Bus Mode bit mask to select best mode.

1a4c11e

When setting Quad Enable, either SR1, SR2 or CR setup is required. Either way register size is up to 2 bytes.

offirko force-pushed the offir_qspi_bus_mask_fix branch from a88dafe to 1a4c11e Compare March 20, 2019 13:31

ciarmcom requested review from a team March 20, 2019 14:00

ciarmcom added the needs: review label Mar 20, 2019

cmonr reviewed Mar 20, 2019

View reviewed changes

components/storage/blockdevice/COMPONENT_QSPIF/QSPIFBlockDevice.cpp Show resolved Hide resolved

cy-vaira reviewed Mar 21, 2019

View reviewed changes

yossi2le approved these changes Mar 27, 2019

View reviewed changes

cmonr added needs: work and removed needs: review labels Mar 27, 2019

If QER is undefined: do nothing but log warning and continue

e8e0fb4

cmonr approved these changes Mar 28, 2019

View reviewed changes

cmonr added needs: CI release-version: 5.12.1 and removed needs: work labels Mar 28, 2019

adbridge added needs: work and removed needs: CI labels Mar 29, 2019

Update QSPIFBlockDevice.cpp

15fdb6e

cmonr added needs: CI and removed needs: work labels Mar 29, 2019

0xc0170 approved these changes Apr 1, 2019

View reviewed changes

0xc0170 added ready for merge and removed needs: CI labels Apr 1, 2019

0xc0170 merged commit 0403883 into ARMmbed:master Apr 1, 2019

0xc0170 removed the ready for merge label Apr 1, 2019

lrusinowicz added a commit to lrusinowicz/mbed-os that referenced this pull request Apr 2, 2019

index on master: 0403883 Merge pull request ARMmbed#10171 from offirk…

73f486d

…o/offir_qspi_bus_mask_fix

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix QSPIF Bus mode mask and quad enable write SR size #10171

Fix QSPIF Bus mode mask and quad enable write SR size #10171

offirko commented Mar 20, 2019 •

edited

Loading

offirko commented Mar 20, 2019 •

edited

Loading

offirko commented Mar 20, 2019

0xc0170 Mar 20, 2019

offirko Mar 20, 2019

0xc0170 Mar 20, 2019

offirko Mar 20, 2019

0xc0170 Mar 20, 2019

vi commented Mar 20, 2019

ciarmcom commented Mar 20, 2019

cy-vaira left a comment •

edited

Loading

yossi2le left a comment

offirko commented Mar 28, 2019

cmonr commented Mar 28, 2019

mbed-ci commented Mar 29, 2019

adbridge commented Mar 29, 2019

cmonr commented Mar 29, 2019

mbed-ci commented Mar 29, 2019

offirko commented Mar 31, 2019

NirSonnenschein commented Mar 31, 2019

mbed-ci commented Mar 31, 2019

offirko commented Mar 31, 2019

mbed-ci commented Apr 1, 2019

0xc0170 commented Apr 1, 2019

Fix QSPIF Bus mode mask and quad enable write SR size #10171

Fix QSPIF Bus mode mask and quad enable write SR size #10171

Conversation

offirko commented Mar 20, 2019 • edited Loading

Pull request type

offirko commented Mar 20, 2019 • edited Loading

offirko commented Mar 20, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vi commented Mar 20, 2019

ciarmcom commented Mar 20, 2019

cy-vaira left a comment • edited Loading

Choose a reason for hiding this comment

yossi2le left a comment

Choose a reason for hiding this comment

offirko commented Mar 28, 2019

cmonr commented Mar 28, 2019

mbed-ci commented Mar 29, 2019

adbridge commented Mar 29, 2019

cmonr commented Mar 29, 2019

mbed-ci commented Mar 29, 2019

offirko commented Mar 31, 2019

NirSonnenschein commented Mar 31, 2019

mbed-ci commented Mar 31, 2019

offirko commented Mar 31, 2019

mbed-ci commented Apr 1, 2019

0xc0170 commented Apr 1, 2019

offirko commented Mar 20, 2019 •

edited

Loading

offirko commented Mar 20, 2019 •

edited

Loading

cy-vaira left a comment •

edited

Loading