Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to configuration information when CPM reports no memories #10187

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

theotherjimmy
Copy link
Contributor

Description

The CY8CKIT targets have a very special memory layout that includes a
memory that is all of:

  • Read
  • Write
  • Execute

This makes CPM report this memory as both a RAM and a ROM. However,
When reported as a RAM, this memory will be filtered out by the build
tools, leaving this target without a defined RAM.

This Pull request corrects the logic to look for a RAM elsewhere in
configuration when this happens.

Fixes #10183

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team March 21, 2019 15:17
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 21, 2019

@ARMmbed/mbed-os-psa Please review - to confirm this is needed in rc4

@0xc0170 0xc0170 requested a review from adbridge March 21, 2019 15:18
@orenc17
Copy link
Contributor

orenc17 commented Mar 21, 2019

tested and ready for rc4

@orenc17 orenc17 mentioned this pull request Mar 21, 2019
@adbridge adbridge requested a review from cmonr March 21, 2019 17:18
@0xc0170 0xc0170 merged commit c475a4a into ARMmbed:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants