Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to configuration information when CPM reports no memories #10187

Merged
merged 1 commit into from Mar 21, 2019

Conversation

Projects
None yet
4 participants
@theotherjimmy
Copy link
Contributor

commented Mar 21, 2019

Description

The CY8CKIT targets have a very special memory layout that includes a
memory that is all of:

  • Read
  • Write
  • Execute

This makes CPM report this memory as both a RAM and a ROM. However,
When reported as a RAM, this memory will be filtered out by the build
tools, leaving this target without a defined RAM.

This Pull request corrects the logic to look for a RAM elsewhere in
configuration when this happens.

Fixes #10183

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-psa Mar 21, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

@ARMmbed/mbed-os-psa Please review - to confirm this is needed in rc4

@0xc0170 0xc0170 requested a review from adbridge Mar 21, 2019

@orenc17

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

tested and ready for rc4

@orenc17 orenc17 referenced this pull request Mar 21, 2019

Merged

Rollup #10189

@adbridge adbridge requested a review from cmonr Mar 21, 2019

@0xc0170 0xc0170 merged commit c475a4a into ARMmbed:master Mar 21, 2019

14 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10268 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: review label Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.