Cellular: Power ON Wait Increased for C030_U201

[mudassar-ublox]

Description

Increased wait for power up of module in CellularDevice test case, as UBLOX_C030_U201 took 10-12 sec to power up.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

[ciarmcom]

@mudassar-ublox, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

[cmonr]

This change feels like the wrong thing to do.

Why does the single target need more time to wait?
(It would also be good to add this information into the commit message as well)

[fahimalavi]

@cmonr
The duration of SARA-U2 series module's switch-on routine can vary depending on the application / network settings and the concurrent module activities. Hard-coded time of 5 seconds is unsafe.

[fahimalavi]

@RobMeades

[mudassar-ublox]

@fahim-ublox & @RobMeades

[RobMeades]

@cmonr: could also just make it 10 seconds for all case, to remove the conditional, it wouldn't do any harm.

[cmonr]

@cmonr: could also just make it 10 seconds for all case, to remove the conditional, it wouldn't do any harm.

@RobMeades @mudassar-ublox I think I'd prefer that solution instead.

[cmonr]

@AriParkkila Thoughts one way or another?

[AriParkkila]

@cmonr I think the proposed change is fine, however :)

It seems that cellular testing will be replaced by the generic Mbed OS netsocket and network-interface tests:

• mbed test -n tests-netsocket-* --app-config=tools/test_configs/CellularInterface.json -vv
• mbed test -n tests-network-interface --app-config=tools/test_configs/CellularInterface.json -vv

[cmonr]

@AriParkkila Not sure I follow your last comment. Could you elaborate?

[AriParkkila]

@cmonr it's fine to add 10 seconds in all cases. However, I probably wouldn't use very much effort on cellular specific Greentea tests anymore due to the generic Mbed OS TESTS for network-interface and netsocket have much better test coverage are now good for cellular testing too.

[cmonr]

and netsocket have much better test coverage are now good for cellular testing too.

Aaah, gotcha. This was the part I wasn't clear on.

[cmonr]

Woudl refer a blanket increase in wait time

[cmonr]

Would prefer a banket wait time.

[cmonr]

@mudassar-ublox If you could update the change to simply be blanket wait time increase, I can approve and get CI started on this.

[mudassar-ublox]

@cmonr pull request is updated. Please review now.

[0xc0170]

For future reference, increase fix like this should contain a reason for increase in the commit msg (why are we changing this from 5 to 10).

[cmonr]

CI started

[mbed-ci]

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts