Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Power ON Wait Increased for C030_U201 #10229

Merged
merged 2 commits into from Apr 2, 2019

Conversation

Projects
None yet
9 participants
@mudassar-ublox
Copy link
Contributor

commented Mar 26, 2019

Description

Increased wait for power up of module in CellularDevice test case, as UBLOX_C030_U201 took 10-12 sec to power up.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Mar 26, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

@mudassar-ublox, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

This change feels like the wrong thing to do.

Why does the single target need more time to wait?
(It would also be good to add this information into the commit message as well)

@fahim-ublox

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@cmonr
The duration of SARA-U2 series module's switch-on routine can vary depending on the application / network settings and the concurrent module activities. Hard-coded time of 5 seconds is unsafe.

@fahim-ublox

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@mudassar-ublox

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

@RobMeades

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@cmonr: could also just make it 10 seconds for all case, to remove the conditional, it wouldn't do any harm.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@cmonr: could also just make it 10 seconds for all case, to remove the conditional, it wouldn't do any harm.

@RobMeades @mudassar-ublox I think I'd prefer that solution instead.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@AriParkkila Thoughts one way or another?

@AriParkkila

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

@cmonr I think the proposed change is fine, however :)

It seems that cellular testing will be replaced by the generic Mbed OS netsocket and network-interface tests:

  • mbed test -n tests-netsocket-* --app-config=tools/test_configs/CellularInterface.json -vv
  • mbed test -n tests-network-interface --app-config=tools/test_configs/CellularInterface.json -vv
@cmonr

cmonr approved these changes Mar 28, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

@AriParkkila Not sure I follow your last comment. Could you elaborate?

@AriParkkila

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

@cmonr it's fine to add 10 seconds in all cases. However, I probably wouldn't use very much effort on cellular specific Greentea tests anymore due to the generic Mbed OS TESTS for network-interface and netsocket have much better test coverage are now good for cellular testing too.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

and netsocket have much better test coverage are now good for cellular testing too.

Aaah, gotcha. This was the part I wasn't clear on.

@cmonr
Copy link
Contributor

left a comment

Woudl refer a blanket increase in wait time

@cmonr
Copy link
Contributor

left a comment

Would prefer a banket wait time.

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

@mudassar-ublox If you could update the change to simply be blanket wait time increase, I can approve and get CI started on this.

@mudassar-ublox

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

@cmonr pull request is updated. Please review now.

@0xc0170 0xc0170 added needs: review and removed needs: work labels Apr 1, 2019

@0xc0170

0xc0170 approved these changes Apr 1, 2019

Copy link
Member

left a comment

For future reference, increase fix like this should contain a reason for increase in the commit msg (why are we changing this from 5 to 10).

@cmonr

cmonr approved these changes Apr 1, 2019

@cmonr cmonr added needs: CI and removed needs: review labels Apr 1, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 2, 2019

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 2, 2019

@0xc0170 0xc0170 merged commit 82e6b2f into ARMmbed:master Apr 2, 2019

21 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+32 bytes)
Details
jenkins-ci/greentea-test Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9090 cycles (-82 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.