Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSOC6: Modify lp_ticker to 32 bit #10267

Merged
merged 1 commit into from Apr 3, 2019

Conversation

Projects
None yet
6 participants
@cy-vivekp
Copy link
Contributor

commented Mar 28, 2019

Description

Increase PSoC6 lpticker to 32 bits

  • Needed for PSoC6 t o deep-sleep for more than 2 seconds
  • Max sleep with 16 bit lp_ticker (before this change) : 2sec
  • Max sleep with 32 bit lp_ticker (after this change) : 36hours

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@amak-cy @cydriftcloud @satya1957

Release Notes

PSOC: Modify lp_ticker to 32 bit
Needed for PSoC to deep-sleep for more than 2 seconds
Max sleep with 16 bit lp_ticker (before this change) : 2sec
Max sleep with 32 bit lp_ticker (after this change)  : 36hours
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

@cy-vivekp, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Mar 29, 2019

@cmonr

cmonr approved these changes Mar 29, 2019

#define MCWDT_COUNTER0_MAX_COUNT (0xffffUL)
#define MCWDT_COUNTER1_MAX_COUNT (0xffffUL)
#define MCWDT_COUNTER2_MAX_COUNT (0xffffffffUL)
#define MAX_MCWDT_DURATION_SEC (35UL*60UL*60UL*1000UL)

This comment has been minimized.

Copy link
@amak-cy

amak-cy Mar 29, 2019

Can this value be a just a number - 126 000 000 Plus comment how it is calculated - In this way is I see that the uint32 is not overflowed

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Apr 2, 2019

Member

This question hasn't been answered. @cy-vivekp Please review

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Max sleep with 16 bit lp_ticker (before this change) : 2sec

Didn't this fail the test - there should be test to deepsleep for few seconds? To catch these?

@cmonr cmonr added needs: review and removed needs: work labels Apr 1, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

@amak-cy

amak-cy approved these changes Apr 1, 2019

@cmonr cmonr added needs: CI and removed needs: review labels Apr 2, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 2, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

I've checked, ticker info supports 16 bit lp ticker so its fine.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

Waiting on the final comment to #10267 (comment)

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

@cy-vivekp Any update?

@amak-cy

This comment has been minimized.

Copy link

commented Apr 3, 2019

@cy-vivekp Any update?

It look like @cy-vivekp wont be available until April 15.
We discussed this internally - I am ok with the current implementation. It is a matter of style. So we can resolve this question

@0xc0170 0xc0170 merged commit 0066ba9 into ARMmbed:master Apr 3, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+32 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 9175 cycles (-693 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.