-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSOC6: Modify lp_ticker to 32 bit #10267
Conversation
Needed for PSoC to deep-sleep for more than 2 seconds Max sleep with 16 bit lp_ticker (before this change) : 2sec Max sleep with 32 bit lp_ticker (after this change) : 36hours
@cy-vivekp, thank you for your changes. |
#define MCWDT_COUNTER0_MAX_COUNT (0xffffUL) | ||
#define MCWDT_COUNTER1_MAX_COUNT (0xffffUL) | ||
#define MCWDT_COUNTER2_MAX_COUNT (0xffffffffUL) | ||
#define MAX_MCWDT_DURATION_SEC (35UL*60UL*60UL*1000UL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this value be a just a number - 126 000 000 Plus comment how it is calculated - In this way is I see that the uint32 is not overflowed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This question hasn't been answered. @cy-vivekp Please review
Didn't this fail the test - there should be test to deepsleep for few seconds? To catch these? |
@cy-vivekp ^^^ |
CI started |
Test run: SUCCESSSummary: 13 of 13 test jobs passed |
I've checked, ticker info supports 16 bit lp ticker so its fine. |
Waiting on the final comment to #10267 (comment) |
@cy-vivekp Any update? |
It look like @cy-vivekp wont be available until April 15. |
Description
Increase PSoC6 lpticker to 32 bits
Pull request type
Reviewers
@amak-cy @cydriftcloud @satya1957
Release Notes