Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSA release.py - Check that required toolchains are in PATH #10335

Merged
merged 1 commit into from Apr 9, 2019
Merged

PSA release.py - Check that required toolchains are in PATH #10335

merged 1 commit into from Apr 9, 2019

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented Apr 7, 2019

Description

Check that required toolchains are in PATH

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@adbridge

Release Notes

@ciarmcom ciarmcom requested review from adbridge and a team April 7, 2019 17:00
@ciarmcom
Copy link
Member

ciarmcom commented Apr 7, 2019

@orenc17, thank you for your changes.
@adbridge @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 8, 2019

As @adbridge is OoO currently, @cmonr please review instead

This fixes the late failures when paths are not set correctly as I understand (experienced these).

@0xc0170 0xc0170 requested review from cmonr and removed request for a team April 8, 2019 10:05
theotherjimmy
theotherjimmy approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

cmonr
cmonr approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cmonr
Copy link
Contributor

cmonr commented Apr 8, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 9, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 680d10f into ARMmbed:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@adbridge adbridge Awaiting requested review from adbridge

Assignees
No one assigned
Labels
release-version: 5.12.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@orenc17 @ciarmcom @0xc0170 @cmonr @mbed-ci @theotherjimmy