Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSA release.py - Check that required toolchains are in PATH #10335

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
6 participants
@orenc17
Copy link
Contributor

commented Apr 7, 2019

Description

Check that required toolchains are in PATH

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@adbridge

Release Notes

@ciarmcom ciarmcom requested review from adbridge and ARMmbed/mbed-os-maintainers Apr 7, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

@orenc17, thank you for your changes.
@adbridge @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

As @adbridge is OoO currently, @cmonr please review instead

This fixes the late failures when paths are not set correctly as I understand (experienced these).

@0xc0170

0xc0170 approved these changes Apr 8, 2019

@0xc0170 0xc0170 requested review from cmonr and removed request for ARMmbed/mbed-os-tools Apr 8, 2019

@theotherjimmy
Copy link
Contributor

left a comment

Looks great!

@cmonr

cmonr approved these changes Apr 8, 2019

Copy link
Contributor

left a comment

🎉

@cmonr cmonr added needs: CI and removed needs: review labels Apr 8, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 9, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr added ready for merge and removed needs: CI labels Apr 9, 2019

@0xc0170 0xc0170 merged commit 680d10f into ARMmbed:master Apr 9, 2019

28 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARMC5 Success
Details
jenkins-ci/build-ARMC6 Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR8 Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARMC5 Success
Details
jenkins-ci/mbed2-build-ARMC6 Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR8 Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Local astyle testing has passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/doxy-spellcheck Local doxy-spellcheck testing has passed
Details
travis-ci/events Passed, runtime is 10296 cycles (+1127 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/include_check Local include_check testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8408B (+0.00%)
Details
travis-ci/psa-autogen Local psa-autogen testing has passed
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
travis-ci/tools-py3.5 Local tools-py3.5 testing has passed
Details
travis-ci/tools-py3.6 Local tools-py3.6 testing has passed
Details
travis-ci/tools-py3.7 Local tools-py3.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.