Correct some CPU selections in tools #10390

kjbracey · 2019-04-12T12:05:45Z

Description

For ARMC6, core types Cortex-M4 and Cortex-M7 did not explicitly add --fpu=none, so it defaulted to assuming FPU present. This would cause a compilation error if the target's cmsis.h had __FPU_PRESENT defined to 0.
For GCC, Cortex-M33FE did not include +dsp in the architecture selection.
For ARMC5 and ARMC6, Cortex-M0+ did not pass M0plus to the non-Clang tools.
Add missing Cortex-M33E DSP Extension without FP possibility.
Switch KW24D to use ARMC6 - it was using ARMC5 because it has non-FP Cortex-M4 and hit this tool problem.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

kjbracey · 2019-04-12T12:07:24Z

Target KW24D is currently marked to not work with ARMC6 - it's possible that this FPU selection problem is the only reason - it's the only real target with Cortex-M4 that doesn't have an FPU. All others actually do, and should have selected Cortex-M4F - other PRs are in to adjust those.

ciarmcom · 2019-04-12T13:00:53Z

@kjbracey-arm, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

bridadan

Nice catch! Looks good to me, probably should run this past @deepikabhavnani too.

deepikabhavnani · 2019-04-12T16:39:48Z

No issue in explicitly setting fpu and dsp options, but it will be good to verify them and make sure all combinations are tested in CI, for some weird reasons I have seen fp is accepted and no_fp not with different compiler versions, don;t remember the exact combinations on top of my head but saw this weird behavior recently.

0xc0170 · 2019-04-15T09:39:05Z

Lets start first CI

kjbracey · 2019-04-15T09:41:17Z

We would have to add a bunch of dummy targets for the as-yet-unused CPU selections. I'm not sure if it's worth it - we would find any problems immediately when someone tries adding a new target.

(This one did pop up with someone adding a non-FP Cortex-M7 in a private repo).

mbed-ci · 2019-04-15T17:35:04Z

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_dynamic-memory-usage
jenkins-ci/mbed-os-ci_greentea-test

alekla01 · 2019-04-15T18:58:18Z

restarted jenkins-ci/mbed-os-ci_dynamic-memory-usage

alekla01 · 2019-04-15T19:03:14Z

restarted jenkins-ci/greentea-test

SenRamakri · 2019-04-16T15:16:34Z

@kjbracey-arm - I think "build-ARM" is failing with KW24D cause its still compiling with ARMC5. Please make a change to targets.json for KW24D to replace "ARMC5" entry with "ARM" in supported_toolchains.

bridadan · 2019-04-16T16:21:30Z

KW24D failed to build with the following error: Fatal error: C3903U: Argument 'Cortex-M4.no_fp' not permitted for option 'cpu'. I think we probably just need to update the cpu flag with the correct combination of Cortex-M4 and "no fpu" option for ARMC5.

@SenRamakri we probably don't want to shift the KW24D to ARMC6 until the target has been verified to work with that right? Is this work already done?

SenRamakri · 2019-04-16T16:58:42Z

@bridadan - This is the change we need to have KW24D(Coretx-M4 targets) working with ARMC6. @studavekar has already verified this.

mbed-ci · 2019-04-16T17:02:24Z

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM

bridadan · 2019-04-16T17:22:28Z

Ah good to know! Thanks @SenRamakri

cmonr · 2019-04-16T17:25:01Z

[DEBUG] Output: Fatal error: C3903U: Argument 'Cortex-M4.no_fp' not permitted for option 'cpu'.
Traceback (most recent call last):
  File "/builds/ws/mbed-os-ci_build-ARM@2/mbed-os/tools/build.py", line 208, in main
    notify = notifier,
  File "/builds/ws/mbed-os-ci_build-ARM@2/mbed-os/tools/build_api.py", line 771, in build_library
    res, res.get_file_paths(FileType.INC_DIR))
  File "/builds/ws/mbed-os-ci_build-ARM@2/mbed-os/tools/toolchains/mbed_toolchain.py", line 457, in compile_sources
    return self.compile_queue(queue, objects)
  File "/builds/ws/mbed-os-ci_build-ARM@2/mbed-os/tools/toolchains/mbed_toolchain.py", line 530, in compile_queue
    raise ToolException(err)
ToolException: Fatal error: C3903U: Argument 'Cortex-M4.no_fp' not permitted for option 'cpu'.

kjbracey · 2019-04-17T08:13:54Z

Adjusted ARMC5 selections - I want to check that makes the KW24D work with ARMC5, then I'll switch it to use ARMC6.

0xc0170 · 2019-04-17T13:00:33Z

CI started

mbed-ci · 2019-04-17T17:49:46Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

alekla01 · 2019-04-17T18:24:11Z

restarted jenkins-ci/greentea-test

* For ARMC6, core types `Cortex-M4` and `Cortex-M7` did not explicitly add `--fpu=none`, so it defaulted to assuming FPU present. This would cause a compilation error if the target's cmsis.h had `__FPU_PRESENT` defined to 0. * For GCC, `Cortex-M33FE` did not include `+dsp` in the architecture selection. * For ARMC5 and ARMC6, `Cortex-M0+` did not pass `M0plus` to the non-Clang tools.

There was a gap in our pattern - we didn't offer M33 with DSP Extension but no floating-point.

KW24D was set to ARMC5 because the ARMC6 tooling didn't correctly handle Cortex-M4 without floating-point. Now fixed.

kjbracey · 2019-04-23T09:19:21Z

Cortex-M7F versus M7FD flags to ARMC6 linker+assembler had got muddled - hopefully fixed now.

SenRamakri · 2019-04-24T21:34:12Z

I started CI on this as it has been pending for more than a day.

mbed-ci · 2019-04-25T01:35:08Z

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

ciarmcom requested review from a team April 12, 2019 13:00

ciarmcom added the needs: review label Apr 12, 2019

bridadan approved these changes Apr 12, 2019

View reviewed changes

0xc0170 added needs: CI release-version: 5.12.2 and removed needs: review labels Apr 15, 2019

0xc0170 approved these changes Apr 15, 2019

View reviewed changes

0xc0170 added ready for merge needs: CI and removed needs: CI ready for merge labels Apr 16, 2019

cmonr added needs: review and removed needs: CI labels Apr 16, 2019

cmonr added needs: work and removed needs: review labels Apr 16, 2019

studavekar mentioned this pull request Apr 16, 2019

pass on asm flags for uVision project #10424

Closed

kjbracey force-pushed the armc6_fpu_sel branch from 147787c to 0fa128d Compare April 17, 2019 08:08

kjbracey force-pushed the armc6_fpu_sel branch from 0fa128d to 6d870ec Compare April 17, 2019 08:25

0xc0170 added needs: CI and removed needs: work labels Apr 17, 2019

kjbracey added 3 commits April 23, 2019 12:04

Tools: Add "Cortex-M33E" option

744e2cc

There was a gap in our pattern - we didn't offer M33 with DSP Extension but no floating-point.

KW24D: Use default ARM compiler (ARMC6)

20ac1c9

KW24D was set to ARMC5 because the ARMC6 tooling didn't correctly handle Cortex-M4 without floating-point. Now fixed.

kjbracey force-pushed the armc6_fpu_sel branch from 642b0a3 to 20ac1c9 Compare April 23, 2019 09:06

adbridge added ready for merge release-version: 5.12.3 and removed needs: CI release-version: 5.12.2 labels Apr 26, 2019

adbridge merged commit c0feb1a into ARMmbed:master Apr 26, 2019

adbridge removed the ready for merge label Apr 26, 2019

orenc17 mentioned this pull request Apr 30, 2019

Fix ARMC6 fpu detection for M33 core #10513

Merged

kjbracey deleted the armc6_fpu_sel branch May 2, 2019 13:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Correct some CPU selections in tools #10390

Correct some CPU selections in tools #10390

kjbracey commented Apr 12, 2019 •

edited

kjbracey commented Apr 12, 2019 •

edited

ciarmcom commented Apr 12, 2019

bridadan left a comment

deepikabhavnani commented Apr 12, 2019

0xc0170 commented Apr 15, 2019

kjbracey commented Apr 15, 2019

mbed-ci commented Apr 15, 2019

alekla01 commented Apr 15, 2019

alekla01 commented Apr 15, 2019

SenRamakri commented Apr 16, 2019

bridadan commented Apr 16, 2019

SenRamakri commented Apr 16, 2019

mbed-ci commented Apr 16, 2019

bridadan commented Apr 16, 2019

cmonr commented Apr 16, 2019

kjbracey commented Apr 17, 2019

0xc0170 commented Apr 17, 2019

mbed-ci commented Apr 17, 2019

alekla01 commented Apr 17, 2019

kjbracey commented Apr 23, 2019 •

edited

SenRamakri commented Apr 24, 2019

mbed-ci commented Apr 25, 2019

Correct some CPU selections in tools #10390

Correct some CPU selections in tools #10390

Conversation

kjbracey commented Apr 12, 2019 • edited

Description

Pull request type

kjbracey commented Apr 12, 2019 • edited

ciarmcom commented Apr 12, 2019

bridadan left a comment

Choose a reason for hiding this comment

deepikabhavnani commented Apr 12, 2019

0xc0170 commented Apr 15, 2019

kjbracey commented Apr 15, 2019

mbed-ci commented Apr 15, 2019

Test run: FAILED

alekla01 commented Apr 15, 2019

alekla01 commented Apr 15, 2019

SenRamakri commented Apr 16, 2019

bridadan commented Apr 16, 2019

SenRamakri commented Apr 16, 2019

mbed-ci commented Apr 16, 2019

Test run: FAILED

bridadan commented Apr 16, 2019

cmonr commented Apr 16, 2019

kjbracey commented Apr 17, 2019

0xc0170 commented Apr 17, 2019

mbed-ci commented Apr 17, 2019

Test run: FAILED

alekla01 commented Apr 17, 2019

kjbracey commented Apr 23, 2019 • edited

SenRamakri commented Apr 24, 2019

mbed-ci commented Apr 25, 2019

Test run: FAILED

kjbracey commented Apr 12, 2019 •

edited

kjbracey commented Apr 12, 2019 •

edited

kjbracey commented Apr 23, 2019 •

edited