Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ARMC6 fpu detection for M33 core #10513

Merged
merged 3 commits into from
May 1, 2019
Merged

Fix ARMC6 fpu detection for M33 core #10513

merged 3 commits into from
May 1, 2019

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented Apr 30, 2019

Description

normal Coretex-M33 was not adding -mfpu=none to the build command
this issue was caused by #10390

This fix is needed for #9221

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@kjbracey-arm @ARMmbed/mbed-os-maintainers

Release Notes

@kjbracey
Copy link
Contributor

Looking at this, I note the M33E (DSP but no FP) addition from #10390 (744e2cc) is missing a bit for ARMC6; it didn't get added to the cpu lookup table above for the compiler, and it would need to be added to the line you're fixing too.

It would be handy if you could fix that at the same time, otherwise, I'll fix it later.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 30, 2019

I was quick to start CI, if updated, @orenc17 let us know, we restart CI

tools/toolchains/arm.py Outdated Show resolved Hide resolved
Add compilation "-mfpu=none" flag for Cortex-M33E.
@alzix
Copy link
Contributor

alzix commented Apr 30, 2019

I was quick to start CI, if updated, @orenc17 let us know, we restart CI

please do

@kjbracey
Copy link
Contributor

Ta, but the cpu table above is also missing the entry "Cortex-M33E": "cortex-m33",

@mbed-ci
Copy link

mbed-ci commented Apr 30, 2019

Test run: FAILED

Summary: 6 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 30, 2019

Aborted, will restart once reviewed again

@orenc17
Copy link
Contributor Author

orenc17 commented Apr 30, 2019

@0xc0170 ready for CI

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 30, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 30, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@adbridge adbridge merged commit 5dab1e4 into ARMmbed:master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants