Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ARMC6 fpu detection for M33 core #10513

Merged
merged 3 commits into from May 1, 2019

Conversation

Projects
None yet
6 participants
@orenc17
Copy link
Contributor

commented Apr 30, 2019

Description

normal Coretex-M33 was not adding -mfpu=none to the build command
this issue was caused by #10390

This fix is needed for #9221

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@kjbracey-arm @ARMmbed/mbed-os-maintainers

Release Notes

@kjbracey-arm

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

Looking at this, I note the M33E (DSP but no FP) addition from #10390 (744e2cc) is missing a bit for ARMC6; it didn't get added to the cpu lookup table above for the compiler, and it would need to be added to the line you're fixing too.

It would be handy if you could fix that at the same time, otherwise, I'll fix it later.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

I was quick to start CI, if updated, @orenc17 let us know, we restart CI

Show resolved Hide resolved tools/toolchains/arm.py Outdated
Handle Cortex-M33E no-fpu flags
Add compilation "-mfpu=none" flag for Cortex-M33E.
@alzix

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

I was quick to start CI, if updated, @orenc17 let us know, we restart CI

please do

@kjbracey-arm

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

Ta, but the cpu table above is also missing the entry "Cortex-M33E": "cortex-m33",

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 30, 2019

Test run: FAILED

Summary: 6 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR
@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

Aborted, will restart once reviewed again

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

@0xc0170 ready for CI

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 30, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@adbridge adbridge added ready for merge and removed needs: CI labels May 1, 2019

@adbridge adbridge merged commit 5dab1e4 into ARMmbed:master May 1, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8619 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.