Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SysTimer should be buildable without lp ticker #10597

Merged
merged 3 commits into from May 22, 2019

Conversation

Projects
None yet
5 participants
@LDong-Arm
Copy link
Contributor

commented May 16, 2019

Description

Tickless from us ticker is possible since #9785, but SysTimer cannot be built if lp ticker is not enabled even if the latter is not used. This PR drops such restriction and is a dependency for #10572 .

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
@kjbracey-arm

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

The equivalent functionality is present in #10104

@LDong-Arm

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

The equivalent functionality is present in #10104

Thanks for letting me know.

This PR is just a quick fix to allow #10572 to proceed, is there a chance we get this done?

@kjbracey-arm

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

If you adjust it to match #10104, retaining the default constructor, then I guess it's fine to proceed.

@@ -119,8 +118,8 @@ class SysTimer: private mbed::TimerEvent, private mbed::NonCopyable<SysTimer> {
static void _set_irq_pending();
us_timestamp_t _time_us;
uint64_t _tick;
bool _suspend_time_passed;
bool _suspended;
bool _suspend_time_passed = true;

This comment has been minimized.

Copy link
@kjbracey-arm

kjbracey-arm May 16, 2019

Contributor

This is C++11, isn't it? We've not activated that yet.

#10104 fixed this in the constructor initializer lists.

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers May 16, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented May 16, 2019

LDong-Arm added some commits May 13, 2019

systimer tests: do not require lp ticker
SysTimer can run on us ticker now. Only deep sleep test
strictly requires lp ticker and it already has build conditions
in place.
mbed_rtx_idle: fix ticker macro checks
If a ticker is unavailable, its macro is undefined and cannot
be checked with MBED_STATIC_ASSERT.

@LDong-Arm LDong-Arm force-pushed the LDong-Arm:systimer_lptimer branch from a4c923d to 427c7db May 16, 2019

@LDong-Arm

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2019

Now the SysTimer constructor is aligned with #10104

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 21, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 21, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented May 21, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 1dbb478 into ARMmbed:master May 22, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8609 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.