SysTimer should be buildable without lp ticker #10597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The equivalent functionality is present in #10104 |
|
If you adjust it to match #10104, retaining the default constructor, then I guess it's fine to proceed. |
kjbracey
reviewed
May 16, 2019
rtos/TARGET_CORTEX/SysTimer.h
Outdated
| @@ -119,8 +118,8 @@ class SysTimer: private mbed::TimerEvent, private mbed::NonCopyable<SysTimer> { | |||
| static void _set_irq_pending(); | |||
| us_timestamp_t _time_us; | |||
| uint64_t _tick; | |||
| bool _suspend_time_passed; | |||
| bool _suspended; | |||
| bool _suspend_time_passed = true; | |||
There was a problem hiding this comment.
This is C++11, isn't it? We've not activated that yet.
#10104 fixed this in the constructor initializer lists.
|
@LDong-Arm, thank you for your changes. |
SysTimer can run on us ticker now. Only deep sleep test strictly requires lp ticker and it already has build conditions in place.
If a ticker is unavailable, its macro is undefined and cannot be checked with MBED_STATIC_ASSERT.
LDong-Arm
force-pushed
the
systimer_lptimer
branch
from
a4c923d
to
427c7db
Compare
|
Now the SysTimer constructor is aligned with #10104 |
kjbracey
approved these changes
May 17, 2019
0xc0170
approved these changes
May 21, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tickless from us ticker is possible since #9785, but SysTimer cannot be built if lp ticker is not enabled even if the latter is not used. This PR drops such restriction and is a dependency for #10572 .
Pull request type