Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove targets FUTURE_SEQUANA_M0_PSA and FUTURE_SEQUANA_PSA #10627

Merged
merged 2 commits into from
May 24, 2019
Merged

Remove targets FUTURE_SEQUANA_M0_PSA and FUTURE_SEQUANA_PSA #10627

merged 2 commits into from
May 24, 2019

Conversation

urutva
Copy link
Contributor

@urutva urutva commented May 21, 2019

Description

The targets FUTURE_SEQUANA_M0_PSA and FUTURE_SEQUANA_PSA are removed due to partial implementation. Having FUTURE_SEQUANA_M0 and
FUTURE_SEQUANA PSA targets is misleading.

Signed-off-by: Devaraj Ranganna devaraj.ranganna@arm.com

Pull request type

[ ] Fix
[ ] Refactor
[ x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@urutva
The targets FUTURE_SEQUANA_M0_PSA and FUTURE_SEQUANA_PSA are removed
7765d39 
due to partial implementation. Having FUTURE_SEQUANA_M0 and
FUTURE_SEQUANA PSA targets is misleading.

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>
@ciarmcom ciarmcom requested review from a team May 21, 2019 17:00
@ciarmcom
Copy link
Member

@Devran01, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-storage please review.

mark-edgeworth
mark-edgeworth approved these changes May 22, 2019
View reviewed changes
Copy link
Contributor

@mark-edgeworth mark-edgeworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've also checked the branch for any other references to FUTURE_SEQUANA*PSA and found none.

@0xc0170 0xc0170 requested review from a team and removed request for a team May 22, 2019 08:06
@0xc0170
Copy link
Contributor

0xc0170 commented May 22, 2019

@Devran01 Was this approved with PSA and Cypress teams?

@ARMmbed/team-cypress Please review

@davidsaada
Copy link
Contributor

@orenc17

orenc17
orenc17 suggested changes May 22, 2019
View reviewed changes
Copy link
Contributor

@orenc17 orenc17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just change the pytest
@0xc0170 as for your concern @MarceloSalazar can explain more

tools/test/config/config_test.py


@pytest.mark.parametrize("target_start_size", [
("FUTURE_SEQUANA_PSA", 0x10080000, 0x78000),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of removing the test entirely, modify it to use CY8CKIT_062_WIFI_BT_M0_PSA and CY8CKIT_062_WIFI_BT_PSA
that way we won't lose coverage

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orenc17 done

@urutva
Replace FUTURE_SEQUANA_M0_PSA and FUTURE_SEQUANA_PSA targets with
29dfab9 
CY8CKIT_062_WIFI_BT_M0_PSA and CY8CKIT_062_WIFI_BT_PSA in config test

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>
@0xc0170 0xc0170 requested a review from bulislaw May 23, 2019 14:04
@0xc0170
Copy link
Contributor

0xc0170 commented May 23, 2019

started CI job to get initial results

@mbed-ci
Copy link

mbed-ci commented May 23, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_exporter

@0xc0170
Copy link
Contributor

0xc0170 commented May 24, 2019

Exporters restarted - license server issue

@0xc0170
Copy link
Contributor

0xc0170 commented May 24, 2019

This is now ready for 5.13

cc @MarceloSalazar

@0xc0170 0xc0170 merged commit ab82f1f into ARMmbed:master May 24, 2019
@urutva urutva deleted the remove_future_sequana_target branch July 2, 2019 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-edgeworth mark-edgeworth mark-edgeworth approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@orenc17 orenc17 orenc17 approved these changes

@bulislaw bulislaw Awaiting requested review from bulislaw

Assignees
No one assigned
Labels
release-version: 5.13.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@urutva @ciarmcom @0xc0170 @davidsaada @mbed-ci @mark-edgeworth @orenc17