Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove targets FUTURE_SEQUANA_M0_PSA and FUTURE_SEQUANA_PSA #10627

Merged
merged 2 commits into from May 24, 2019

Conversation

Projects
None yet
7 participants
@devran01
Copy link
Contributor

commented May 21, 2019

Description

The targets FUTURE_SEQUANA_M0_PSA and FUTURE_SEQUANA_PSA are removed due to partial implementation. Having FUTURE_SEQUANA_M0 and
FUTURE_SEQUANA PSA targets is misleading.

Signed-off-by: Devaraj Ranganna devaraj.ranganna@arm.com

Pull request type

[ ] Fix
[ ] Refactor
[ x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

The targets FUTURE_SEQUANA_M0_PSA and FUTURE_SEQUANA_PSA are removed
due to partial implementation. Having FUTURE_SEQUANA_M0 and
FUTURE_SEQUANA PSA targets is misleading.

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers May 21, 2019

@ciarmcom

This comment has been minimized.

@mark-edgeworth
Copy link
Contributor

left a comment

Looks good to me. I've also checked the branch for any other references to FUTURE_SEQUANA*PSA and found none.

@0xc0170 0xc0170 requested review from ARMmbed/team-cypress and removed request for ARMmbed/mbed-os-storage May 22, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 22, 2019

@devran01 Was this approved with PSA and Cypress teams?

@ARMmbed/team-cypress Please review

@davidsaada

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

@orenc17
Copy link
Contributor

left a comment

looks good, just change the pytest
@0xc0170 as for your concern @MarceloSalazar can explain more



@pytest.mark.parametrize("target_start_size", [
("FUTURE_SEQUANA_PSA", 0x10080000, 0x78000),

This comment has been minimized.

Copy link
@orenc17

orenc17 May 22, 2019

Contributor

instead of removing the test entirely, modify it to use CY8CKIT_062_WIFI_BT_M0_PSA and CY8CKIT_062_WIFI_BT_PSA
that way we won't lose coverage

This comment has been minimized.

Copy link
@devran01

devran01 May 22, 2019

Author Contributor

@orenc17 done

Replace FUTURE_SEQUANA_M0_PSA and FUTURE_SEQUANA_PSA targets with
CY8CKIT_062_WIFI_BT_M0_PSA and CY8CKIT_062_WIFI_BT_PSA in config test

Signed-off-by: Devaraj Ranganna <devaraj.ranganna@arm.com>
@0xc0170

This comment has been minimized.

Copy link
Member

commented May 23, 2019

started CI job to get initial results

@mbed-ci

This comment has been minimized.

Copy link

commented May 23, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_exporter
@0xc0170

This comment has been minimized.

Copy link
Member

commented May 24, 2019

Exporters restarted - license server issue

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 24, 2019

This is now ready for 5.13

cc @MarceloSalazar

@0xc0170 0xc0170 merged commit ab82f1f into ARMmbed:master May 24, 2019

25 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8601 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@devran01 devran01 deleted the devran01:remove_future_sequana_target branch Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.