Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TARGET_STM: SPI: add pulse on master transmissions #10708

Merged
merged 1 commit into from
Jun 9, 2019

Conversation

VVESTM
Copy link
Contributor

@VVESTM VVESTM commented May 29, 2019

Description

Add a pulse when using hardware chip select for SPI transmissions.
CS is at low level when a transmission is on-going.

Be careful, this is not compatible with all modes. It will work only
if PHA is 0, ie spi mode is 0 or 2. See stm32xx reference manual,
chapter "NSS pulse mode" for more details.

Fix #10671

Pull request type

[x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@VVESTM
Copy link
Contributor Author

VVESTM commented May 29, 2019

Tests on-going...

@ciarmcom ciarmcom requested a review from a team May 29, 2019 15:01
@ciarmcom
Copy link
Member

@VVESTM, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

Add a pulse when using hardware chip select for SPI transmissions.
CS is at low level when a transmission is on-going.

Be careful, this is not compatible with all modes. It will work only
if PHA is 0, ie spi mode is 0 or 2. See stm32xx reference manual,
chapter "NSS pulse mode" for more details.

Fix ARMmbed#10671

Signed-off-by: Vincent Veron <vincent.veron@st.com>
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ST CI tests OK for all STM32 families

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 7, 2019

Ci started

@mbed-ci
Copy link

mbed-ci commented Jun 8, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit ced4c3f into ARMmbed:master Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSEL not working on STM32F NUCLEO_F767ZI
6 participants