-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix networkinterface non-blocking status test #10761
Conversation
@jarvte, thank you for your changes. |
I don't fully understand why would extra disconnect messages be sent to callback if the socket has already been disconnected? Maybe it is better to prevent them being sent? The test seems to be well tailored... In case there is a good reason to keep sending messages to callback after socket got disconnected... Do we know how many messages are expected? Perhaps we can consciously receive them, to make sure nothing will spuriously break the subsequent connect()? Is only this one particular test affected or do other tests also need to wait for pending messages to arrive? |
Not socket.. this is for NetworkInterface. And in theory, you cannot destroy interface, but you can destroy socket. |
Fix was to add some time between iterations connect-disconnect. In cellular disconnect, cellular network may send disconnect events and if those events come when connect is already ongoing test will fail. So wait a bit after disconnect so that disconnect events should be over.
4bd4f46
to
2b9e1f3
Compare
Force-pushed astyle fixes |
CI started |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Description
Fix was to add some time between iterations connect-disconnect. In cellular disconnect, cellular network may send disconnect events and if those events come when connect is already ongoing test will fail.
So wait a bit after disconnect so that disconnect events should be over.
Pull request type
Reviewers
@AriParkkila
Release Notes