Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lp ticker and common ticker tests #11167

Merged
merged 2 commits into from
Aug 13, 2019
Merged

Fix lp ticker and common ticker tests #11167

merged 2 commits into from
Aug 13, 2019

Conversation

Tharazi97
Copy link
Contributor

Description

Simple changes that fix lp ticker and common tickers failing tests (NUCLEO_L073RZ, DISCO_L475VG_IOT01A).

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@jamesbeyond @maciejbocianski @mprse

Release Notes

@ciarmcom
Copy link
Member

ciarmcom commented Aug 5, 2019

@Tharazi97, thank you for your changes.
@maciejbocianski @jamesbeyond @mprse @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

mprse
mprse approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@mprse mprse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

maciejbocianski
maciejbocianski approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@maciejbocianski maciejbocianski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jamesbeyond
jamesbeyond approved these changes Aug 8, 2019
View reviewed changes
Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jamesbeyond
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 8, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@Tharazi97
Copy link
Contributor Author

CI failed, looks not related.
"test suite 'mbed-os-tests-psa-crypto_access_control' ......................................... TIMEOUT in 1800.85 sec"

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 9, 2019

Restarting CI

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 9, 2019

cc @ARMmbed/mbed-os-test - early failures in Jenkins

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 9, 2019

Our test team will investigate this failure.

@OPpuolitaival
Copy link
Contributor

Re triggered CI

@mbed-ci
Copy link

mbed-ci commented Aug 12, 2019

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 4
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 12, 2019

Waiting for pr-merge fix , cc @ARMmbed/mbed-os-test

@0xc0170 0xc0170 merged commit 80556a0 into ARMmbed:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejbocianski maciejbocianski maciejbocianski approved these changes

@mprse mprse mprse approved these changes

@jamesbeyond jamesbeyond jamesbeyond approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Tharazi97 @ciarmcom @jamesbeyond @mbed-ci @0xc0170 @OPpuolitaival @maciejbocianski @mprse