Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIMXRT1050_EVK: Add TRNG support #11188

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Conversation

mmahadevan108
Copy link
Contributor

Description

Add TRNG support

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@mmahadevan108
Copy link
Contributor Author

Below are the test results:
mbedgt: test on hardware with target id: 0227000041114e450004300ac2040020df91000097969900
mbedgt: test suite 'mbed-os-tests-mbed_hal-trng' ..................................................... OK in 12.50 sec
test case: 'mbed-os-tests-mbed_hal-trng' ..................................................... OK in 12.50 sec
mbedgt: test case summary: 1 pass, 0 failures
mbedgt: all tests finished!
mbedgt: shuffle seed: 0.6729389334
mbedgt: test suite report:

target platform_name test suite result elapsed_time (sec) copy_method
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-trng OK 12.5 default
mbedgt: test suite results: 1 OK
mbedgt: test case report:
target platform_name test suite test case passed failed
esult elapsed_time (sec)
------------------------ ---------------- ----------------------------- ----------------------------- -------- --------
------ --------------------
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-mbed_hal-trng mbed-os-tests-mbed_hal-trng 1 0
K 12.5
mbedgt: test case results: 1 OK

@mmahadevan108
Copy link
Contributor Author

cc @maclobdell

@ciarmcom ciarmcom requested review from maclobdell and a team August 8, 2019 17:00
@ciarmcom
Copy link
Member

ciarmcom commented Aug 8, 2019

@mmahadevan108, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from a team August 9, 2019 07:18
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 9, 2019

@ARMmbed/mbed-os-crypto please review TRNG implementation

@yanesca
Copy link
Contributor

yanesca commented Aug 12, 2019

Hi, I am trying to review based on this:
http://www.mouser.com/ds/2/813/K66P144M180SF5RMV2-1074869.pdf

I am trying to understand how the value of a single output register the manual talks about gets into the 16 registers the code in targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT1050/drivers/fsl_trng.c reads it from. Am I looking at the wrong manual?

@mmahadevan108
Copy link
Contributor Author

Please refer to the MXRT1050 manual at the below link:
https://www.nxp.com/docs/en/reference-manual/IMXRT1050RM.pdf

*/

/*
* Reference: "K66 Sub-Family Reference Manual, Rev. 2", chapter 38
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we please correct this reference to "i.MX RT1050 Processor ReferenceManual" Section 6.6?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting this, I have updated the file to correct this.

@yanesca
Copy link
Contributor

yanesca commented Aug 15, 2019

@mmahadevan108 Thank you very much for the link! There is a short section about the TRNG and some information about the corresponding registers. What I was looking for is an estimate about the entropy content of the 512 output bits. Is that information available somewhere?

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108
Copy link
Contributor Author

Apologies for the lack of information in the reference manual. I do see a security manual at the below link, however this manual is not publicly available and will have to be requested through the NXP FAE person that ARM works with.

https://www.nxp.com/products/processors-and-microcontrollers/arm-microcontrollers/i.mx-rt-series/i.mx-rt1050-crossover-processor-with-arm-cortex-m7-core:i.MX-RT1050?tab=Documentation_Tab

Unfortunately I have no information on the entropy contents.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 19, 2019

@yanesca How can we progress this?

@yanesca
Copy link
Contributor

yanesca commented Aug 19, 2019

I've got the documentation, I am going read it and review the PR as soon as I can find the time.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 19, 2019

Ci started

@mbed-ci
Copy link

mbed-ci commented Aug 20, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants