-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update googletest to v1.8.1 #11486
update googletest to v1.8.1 #11486
Conversation
@ladislas, thank you for your changes. |
👍 for using the version rather than SHA @ARMmbed/mbed-os-test Please review |
@ARMmbed/mbed-os-test bump - please review (@jamesbeyond fyi) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a line in the readme:
https://github.com/ARMmbed/mbed-os/blob/master/UNITTESTS/README.md#writing-unit-tests
Saying this is using google tests v1.8.1 ?
@jamesbeyond Just updated the readme, let me know if it works for you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! thanks @ladislas
CI started |
Description
The PR updated googletest to v1.8.1. It avoids having a "random" commit used.
Tested with
cmake ..
and gcc on macOS,but could not testAND withmbed test --unittests
but could not complete (see #11485) -- googletest compiles correctly at the beginning though.The update needs a small change in CMakeLists.txt, based on that: google/googletest#1764 (comment)
Pull request type
Reviewers
n/a
Release Notes
n/a