Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable DER coded certificate support to Wi-SUN mesh API #11539

Merged
merged 1 commit into from Oct 15, 2019
Merged

Enable DER coded certificate support to Wi-SUN mesh API #11539

merged 1 commit into from Oct 15, 2019

Conversation

mikaleppanen
Copy link

Description

Wi-SUN mesh API uses now nanostack certificate interface with length parameters. This enables that either PEM or DER formatted certificates can be used. Using the length configuration for certificates and keys is optional, so existing applications using the PEM certificates do not require changes.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mikter

Release Notes

Added support for DER formatted certificates and keys to Wi-SUN certificate API.

Enabled DER coded certificate support to Wi-SUN mesh API
47e5dd7 
Wi-SUN mesh API uses now nanostack certificate interface with length parameters.
This enables that either PEM or DER formatted certificates can be used. Using
the length configuration for certificates and keys is optional, so existing
applications using the PEM certificates do not require changes.
@ciarmcom ciarmcom requested review from mikter and a team September 20, 2019 11:00
@ciarmcom
Copy link
Member

@mikaleppanen, thank you for your changes.
@mikter @ARMmbed/mbed-os-mesh @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 1, 2019

@ARMmbed/mbed-os-ipcore Please review

@adbridge
Copy link
Contributor

adbridge commented Oct 3, 2019

@bulislaw is this also ok for 5.15 ?

@bulislaw
Copy link
Member

bulislaw commented Oct 3, 2019

@mikter I'm assuming all things WiSun are needed for 5.15?

@mikter
Copy link

mikter commented Oct 3, 2019

Yes these are 5.15 delivery content

bulislaw
bulislaw approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get it for 5.15

@adbridge
Copy link
Contributor

adbridge commented Oct 7, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 7, 2019

Test run: FAILED

Summary: 2 of 12 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_wisun-mesh-test

@mikaleppanen
Copy link
Author

mikaleppanen commented Oct 8, 2019 •
edited

jenkins-ci/mbed-os-ci_wisun-mesh-test fails because test waits for too short time for Wi-SUN bootstrap to complete. Test should be modified so that it waits for longer:

16:34:02.910 | D1 <<< DutThread: [INFO][wsbs]: Discovery start
.....
16:34:03.011 | D1 <<< DutThread: [DBG ][wsbs]: Disc params imin 300, imax 9600, expirations 255, k 1 PAS Trickle I 8944 t 7653, now 0, c 0
....
16:47:22.299 | D1 <<< DutThread: [INFO][wsbs]: authentication start
.....
16:49:34.963 | D1 <<< DutThread: [DBG ][wsbs]: Start RPL learn
....
16:51:34.373 | D1 <<< DutThread: [INFO][rplc]: DIO from fe80::647f:449c:9af2:e24a, rank c4
16:51:34.515 | D1 <-> MainThread: Close 'D1' connection

------- test ends before RPL completes ------

@mikter

@mikaleppanen
Copy link
Author

jenkins-ci/mbed-os-ci_cloud-client-test could be some temporary problem, cannot find any connections attemps made wit Wi-SUN (test seems to use at least ethernet)

@0xc0170 0xc0170 changed the title Enabled DER coded certificate support to Wi-SUN mesh API Enabl DER coded certificate support to Wi-SUN mesh API Oct 14, 2019
@0xc0170 0xc0170 changed the title Enabl DER coded certificate support to Wi-SUN mesh API Enable DER coded certificate support to Wi-SUN mesh API Oct 14, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 14, 2019

I restarted both tests

@0xc0170 0xc0170 merged commit 57c4a08 into ARMmbed:master Oct 15, 2019
@mikaleppanen mikaleppanen mentioned this pull request Oct 15, 2019
Merged
0xc0170 added a commit that referenced this pull request Oct 15, 2019
@0xc0170
Merge pull request #11686 from mikaleppanen/nano_cont_corr
0ca6433 
Corrected nanostack PAE controller

Changes on #11539 conflicted with nanostack changes on master. Removed the duplicated functions from PAE controller.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@mikter mikter mikter approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mikaleppanen @ciarmcom @0xc0170 @adbridge @bulislaw @mikter @mbed-ci