Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Simplify pull request template #11563
Now looks like:
Summary of change (What the change is for and why)
Condense multiple options into the main three and summarize what
Add a test results section.
Added additional guidance
Documentation (Details of any document updates required)
Updates required to workflow docs
Pull request type (required)
Test results (required)
Release Notes (required for feature/major PRs)
Summary of changes
Impact of changes
Migration actions required
0xc0170 left a comment •
A comment to "Tests" section only, the rest looks fine to me.
Are "Tests" required or optional? the header states required, then in the comment it is optional?
I am not certain about "covered by existing tests and CI" - most of people have no idea what runs in CI, so would remove "and CI" but that might be just me being picky.
"Tests supplied below" - rather add "Test results" ?
BTW, how about documentation section? are we still having that section?
Docs covered in the Patch update.
If not any of these 3, the text below these 3 options is "others" - does it need own item in the list?
Not sure what 'others' would be? Pretty sure those 3 cover everything. Either no testing, testing covered by us or else they need to supply evidence...