Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baremetal profile fixes #11683

Merged
merged 2 commits into from Nov 4, 2019

Conversation

@AnttiKauppila
Copy link
Contributor

AnttiKauppila commented Oct 14, 2019

Description

Flagged out Thread usage from Cellular stack when RTOS is not used. Also L3IP source code was flagged out similarly than it's header.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@yogpan01 @teetak01 @ARMmbed/mbed-os-wan

Release Notes

Cellular stack is made to be Baremetal compliant.

@ciarmcom ciarmcom requested review from teetak01, yogpan01 and ARMmbed/mbed-os-maintainers Oct 14, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 14, 2019

Copy link
Contributor

kivaisan left a comment

LGTM, but maybe this could be split into 2 separate commits: cellular and L3IP.

Copy link
Contributor

yogpan01 left a comment

Looks good to me. This should land in mbed-os5.14.2 release since this enables to prepare client for bare metal configuration across different connectivity stacks.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 21, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 21, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 21, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 22, 2019

Unittests failed : [2019-10-21T13:39:21.251Z] 15 - features-cellular-framework-device-cellularstatemachine (Failed), please review

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Oct 22, 2019
@AnttiKauppila AnttiKauppila force-pushed the AnttiKauppila:baremetal_support branch from 3afc762 to ac0b0f1 Nov 1, 2019
@AnttiKauppila AnttiKauppila added needs: CI and removed needs: work labels Nov 1, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Nov 4, 2019

CI started

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Nov 4, 2019

@AnttiKauppila Please leave a comment once you update the PR, to provide status update. I can see the force rebase, so unittest should be fixed

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Nov 4, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Nov 4, 2019

Ci internal error, restarted

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Nov 4, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@AnttiKauppila AnttiKauppila removed the needs: CI label Nov 4, 2019
@0xc0170 0xc0170 merged commit fe94092 into ARMmbed:master Nov 4, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8662 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8420B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@0xc0170 0xc0170 removed the ready for merge label Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.