Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baremetal profile fixes #11683

Merged
merged 2 commits into from
Nov 4, 2019
Merged

Baremetal profile fixes #11683

merged 2 commits into from
Nov 4, 2019

Conversation

AnttiKauppila
Copy link

Description

Flagged out Thread usage from Cellular stack when RTOS is not used. Also L3IP source code was flagged out similarly than it's header.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@yogpan01 @teetak01 @ARMmbed/mbed-os-wan

Release Notes

Cellular stack is made to be Baremetal compliant.

@ciarmcom ciarmcom requested review from teetak01, yogpan01 and a team October 14, 2019 13:00
@ciarmcom
Copy link
Member

@AnttiKauppila, thank you for your changes.
@yogpan01 @teetak01 @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

kivaisan
kivaisan approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@kivaisan kivaisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe this could be split into 2 separate commits: cellular and L3IP.

yogpan01
yogpan01 approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@yogpan01 yogpan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This should land in mbed-os5.14.2 release since this enables to prepare client for bare metal configuration across different connectivity stacks.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 21, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 21, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 22, 2019

Unittests failed : [2019-10-21T13:39:21.251Z] 15 - features-cellular-framework-device-cellularstatemachine (Failed), please review

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 4, 2019

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 4, 2019

@AnttiKauppila Please leave a comment once you update the PR, to provide status update. I can see the force rebase, so unittest should be fixed

@mbed-ci
Copy link

mbed-ci commented Nov 4, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 4, 2019

Ci internal error, restarted

@mbed-ci
Copy link

mbed-ci commented Nov 4, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 merged commit fe94092 into ARMmbed:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@yogpan01 yogpan01 yogpan01 approved these changes

@AriParkkila AriParkkila AriParkkila approved these changes

@kivaisan kivaisan kivaisan approved these changes

@teetak01 teetak01 Awaiting requested review from teetak01

Assignees
No one assigned
Labels
release-version: 5.14.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AnttiKauppila @ciarmcom @0xc0170 @mbed-ci @yogpan01 @AriParkkila @kivaisan