Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the internal kvstore flash reservation size to from 7k to 65K for Cypress Devices #11747

Merged
merged 1 commit into from Oct 25, 2019

Conversation

@miteshdedhia7
Copy link

miteshdedhia7 commented Oct 24, 2019

Description

Updated the internal flash available for kvstore from 7K to 65K.
This fixes the features-storage-tests-kvstore-static_tests failure for Cypress devices that do not have external flash capability (QSPIF). The 7K initially allocated is not enough for the devices that use the internal flash for kvstore.
For example, The test fails in the GT reports attached to the PR, #11561
GT test report after fix,
GT_FT_PROTO_063_BLE_GCC.txt

This change should only impact Cypress devices with no external flash.

GT test reports for other devices,
GT_FT_KIT_062_BLE_GCC.txt
GT_FT_KIT_062_WIFI_BT_GCC.txt
GT_FT_KIT_062S2_43012_GCC.txt
GT_FT_KIT_EVB_43012_GCC.txt
GT_FT_PROTO_062_4343W_GCC.txt

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/team-cypress

Release Notes

…e the internal flash for kvstore
@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Oct 24, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 24, 2019

@miteshdedhia7, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from ARMmbed/team-cypress Oct 25, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 25, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 25, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit e1c3de6 into ARMmbed:master Oct 25, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8177 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8420B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@miteshdedhia7 miteshdedhia7 deleted the miteshdedhia7:pr/fix-kvstore-statictests branch Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.