-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPC55S69: fix serial_set_flow_control #11775
LPC55S69: fix serial_set_flow_control #11775
Conversation
@maciejbocianski, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ARMmbed/team-nxp @mmahadevan108 , please take a look this fix |
CI started meanwhile |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Description (required)
Fix
serial_set_flow_control
implementation forLPC55S69
Skip pin setting if
NC
example call causing assert:
serial_set_flow_control(..., FlowControlNone, NC, NC)
Problem revealed by #10924
Summary of change (What the change is for and why)
Documentation (Details of any document updates required)
Pull request type (required)
Test results (required)
Reviewers (optional)
Release Notes (required for feature/major PRs)
Summary of changes
Impact of changes
Migration actions required