Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPC55S69: fix serial_set_flow_control #11775

Merged

Conversation

@maciejbocianski
Copy link
Member

maciejbocianski commented Oct 30, 2019

Description (required)

Fix serial_set_flow_control implementation for LPC55S69
Skip pin setting if NC
example call causing assert: serial_set_flow_control(..., FlowControlNone, NC, NC)

Problem revealed by #10924

Summary of change (What the change is for and why)
Documentation (Details of any document updates required)

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)


Release Notes (required for feature/major PRs)

Summary of changes
Impact of changes
Migration actions required
@ciarmcom ciarmcom requested review from maclobdell and ARMmbed/mbed-os-maintainers Oct 30, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 30, 2019

@maciejbocianski, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

jamesbeyond left a comment

LGTM

@jamesbeyond

This comment has been minimized.

Copy link
Contributor

jamesbeyond commented Nov 4, 2019

@ARMmbed/team-nxp @mmahadevan108 , please take a look this fix

@0xc0170
0xc0170 approved these changes Nov 5, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Nov 5, 2019

CI started meanwhile

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Nov 5, 2019
@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Nov 5, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

Copy link
Contributor

mmahadevan108 left a comment

Thank you

@0xc0170 0xc0170 merged commit e4164be into ARMmbed:master Nov 5, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8678 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8420B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@0xc0170 0xc0170 removed the ready for merge label Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.