Make SMS configurable in Cellular stack #11873

AnttiKauppila · 2019-11-15T14:02:24Z

Description

Put SMS behind configuration flag to save some memory (4,5kB) for Cellular users not needing SMS features.
UBlox N2XX target is also updated

Summary of change (What the change is for and why)

Unittests have been updated also

Documentation (Details of any document updates required)

Pull request type (required)

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)

@AriParkkila @mirelachirica @JanneKiiskila @anttiylitokola

Release Notes (required for feature/major PRs)

Summary of changes

Cellular stack has now configurable SMS support. This is added to Cellular mbed_lib.json. It is enabled by default for backward compatibility.

Impact of changes

If one does not need SMS, disable it in mbed_app.json to decrease the application footprint.

Migration actions required

None

ciarmcom · 2019-11-15T16:00:32Z

@AnttiKauppila, thank you for your changes.
@AriParkkila @mirelachirica @JanneKiiskila @anttiylitokola @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

JanneKiiskila · 2019-11-15T16:38:30Z

features/cellular/framework/API/CellularDevice.h

@@ -314,6 +314,7 @@ class CellularDevice {
     */
    virtual CellularNetwork *open_network(FileHandle *fh = NULL) = 0;

+#if MBED_CONF_CELLULAR_USE_SMS || defined(DOXYGEN_ONLY)
    /** Create new CellularSMS interface.
     *
     *  @param fh    file handle used in communication to modem. This can be, for example, UART handle. If null, then the default


Should the trick how to enable this via the mbed_app.json target override be added here or?

JanneKiiskila

Activation tip somewhere, looks otherwise just fine!

AnttiKauppila · 2019-11-18T07:00:26Z

Activation tip somewhere, looks otherwise just fine!

Like I have put in mbed_lib.json?

JanneKiiskila · 2019-11-18T10:16:01Z

Activation tip somewhere, looks otherwise just fine!

Like I have put in mbed_lib.json?

Well, that's not quite enough - we don't want people to modify the mbed_lib.json files, they should understand how to override that in their own mbed_app.json instead, using the target overrides. But, I think that should probably be in the cellular API docs instead - the example "add these lines to your mbed_app.json to get SMS API enabled..." type of thing.

0xc0170 · 2019-11-19T14:37:15Z

Disable SMS by default from Cellular stack

Please amend the commit msg with details shared above (why is this disabled).

AnttiKauppila · 2019-11-25T09:35:48Z

Activation tip somewhere, looks otherwise just fine!

Like I have put in mbed_lib.json?

Well, that's not quite enough - we don't want people to modify the mbed_lib.json files, they should understand how to override that in their own mbed_app.json instead, using the target overrides. But, I think that should probably be in the cellular API docs instead - the example "add these lines to your mbed_app.json to get SMS API enabled..." type of thing.

But Janne, this is the DEFAULT Mbed OS configuration mechanism, nobody should modify mbed_lib.json anywhere but override the config as per our documentation: https://os.mbed.com/docs/mbed-os/v5.14/reference/configuration.html
And you can list cellular specific configurations like this:
mbed compile --config --prefix cellular

What else do you need?

Put SMS behind configuration flag to save some memory (4,5kB) for Cellular users not needing SMS features. UBlox N2XX target is also updated

AnttiKauppila · 2019-11-25T09:39:17Z

@0xc0170 Commit msg updated

0xc0170 · 2019-11-25T09:40:49Z

will start CI as soon as some 5.15 jobs complete

0xc0170 · 2019-11-25T15:22:56Z

CI started

mbed-ci · 2019-11-25T16:40:39Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

0xc0170 · 2019-11-26T14:52:40Z

CI started

mbed-ci · 2019-11-26T16:08:42Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

ciarmcom requested review from anttiylitokola, AriParkkila, JanneKiiskila, mirelachirica and a team November 15, 2019 16:00

ciarmcom added the needs: review label Nov 15, 2019

JanneKiiskila reviewed Nov 15, 2019

View reviewed changes

JanneKiiskila suggested changes Nov 15, 2019

View reviewed changes

AnttiKauppila added the release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 label Nov 18, 2019

0xc0170 added the BREAKING-CHANGE label Nov 19, 2019

AriParkkila approved these changes Nov 20, 2019

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Nov 21, 2019

Disable SMS by default from Cellular stack

353782b

Put SMS behind configuration flag to save some memory (4,5kB) for Cellular users not needing SMS features. UBlox N2XX target is also updated

AnttiKauppila force-pushed the disable_sms branch from 64add0f to 353782b Compare November 25, 2019 09:38

AnttiKauppila added needs: CI and removed needs: work labels Nov 25, 2019

0xc0170 approved these changes Nov 25, 2019

View reviewed changes

0xc0170 added ready for merge and removed needs: CI labels Nov 26, 2019

Enabled SMS by default to not break anything

cb806be

AnttiKauppila added needs: CI and removed ready for merge release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 BREAKING-CHANGE labels Nov 26, 2019

AnttiKauppila changed the title ~~Disable SMS by default from Cellular stack~~ Make SMS configurable in Cellular stack Nov 26, 2019

JanneKiiskila approved these changes Nov 26, 2019

View reviewed changes

AnttiKauppila added the release-version: 5.15.0-rc1 label Nov 26, 2019

0xc0170 removed the needs: CI label Nov 27, 2019

0xc0170 merged commit 58d6f5f into ARMmbed:master Nov 27, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make SMS configurable in Cellular stack #11873

Make SMS configurable in Cellular stack #11873

AnttiKauppila commented Nov 15, 2019 •

edited by 0xc0170

Loading

ciarmcom commented Nov 15, 2019

JanneKiiskila Nov 15, 2019

JanneKiiskila left a comment

AnttiKauppila commented Nov 18, 2019

JanneKiiskila commented Nov 18, 2019

0xc0170 commented Nov 19, 2019

AnttiKauppila commented Nov 25, 2019

AnttiKauppila commented Nov 25, 2019

0xc0170 commented Nov 25, 2019

0xc0170 commented Nov 25, 2019

mbed-ci commented Nov 25, 2019

0xc0170 commented Nov 26, 2019

mbed-ci commented Nov 26, 2019

Make SMS configurable in Cellular stack #11873

Make SMS configurable in Cellular stack #11873

Conversation

AnttiKauppila commented Nov 15, 2019 • edited by 0xc0170 Loading

Description

Summary of change (What the change is for and why)

Documentation (Details of any document updates required)

Pull request type (required)

Test results (required)

Reviewers (optional)

@AriParkkila @mirelachirica @JanneKiiskila @anttiylitokola

Release Notes (required for feature/major PRs)

Summary of changes

Impact of changes

Migration actions required

ciarmcom commented Nov 15, 2019

JanneKiiskila Nov 15, 2019

Choose a reason for hiding this comment

JanneKiiskila left a comment

Choose a reason for hiding this comment

AnttiKauppila commented Nov 18, 2019

JanneKiiskila commented Nov 18, 2019

0xc0170 commented Nov 19, 2019

AnttiKauppila commented Nov 25, 2019

AnttiKauppila commented Nov 25, 2019

0xc0170 commented Nov 25, 2019

0xc0170 commented Nov 25, 2019

mbed-ci commented Nov 25, 2019

Test run: SUCCESS

0xc0170 commented Nov 26, 2019

mbed-ci commented Nov 26, 2019

Test run: SUCCESS

AnttiKauppila commented Nov 15, 2019 •

edited by 0xc0170

Loading