Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target for CYW9P62S1_43438EVB_01 #11887

Merged
merged 3 commits into from
Nov 25, 2019

Conversation

kyle-cypress
Copy link

@kyle-cypress kyle-cypress commented Nov 19, 2019

Description (required)

Add target for CYW9P62S1_43438EVB_01
This depends on PR #11884

Summary of change (What the change is for and why)
Documentation (Details of any document updates required)

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

GT_FT_P6S1_43438EVB_01_GCC.txt
NOTE: The kvstore failures are due to #11879. The sleep failures are due to a known incompatibility between the sleep tests and our UART driver.

GT_FT_P6S1_43438EVB_01_GCC_NET.txt
NOTE: The failures are known issues with the integration test suite which we recently enabled. They apply across Cypress targets and will be fixed in a future PR.

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Reviewers (optional)

@ARMmbed/team-cypress


Release Notes (required for feature/major PRs)

Summary of changes
Impact of changes
Migration actions required

@ciarmcom ciarmcom requested review from maclobdell and a team November 19, 2019 02:00
@ciarmcom
Copy link
Member

@kyle-cypress, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@kyle-cypress
Copy link
Author

Pushed an update to remove board-specific PeripheralNames.h and PinNames.h that are made obsolete by #11884 .

@kyle-cypress
Copy link
Author

The BT firmware has been added and this is ready to go once #11884 is merged.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2019

This depends on PR #11884

Is this that one 11884 PR is in , this one will be rebased and ready for integration? Just trying to understand the dependencies

@kyle-cypress
Copy link
Author

kyle-cypress commented Nov 22, 2019

This depends on PR #11884

Is this that one 11884 PR is in , this one will be rebased and ready for integration? Just trying to understand the dependencies

There is no "hard" commit dependency. I.e. all of the commits here will apply cleanly both to current master and after #11884 is merged. However, this target assumes changes to the common Cypress target code in #11884 and will not compile cleanly without them.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 25, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 25, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 25, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Nov 25, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 removed the needs: CI label Nov 25, 2019
@0xc0170 0xc0170 merged commit a169edf into ARMmbed:master Nov 25, 2019
@kyle-cypress kyle-cypress deleted the pr/target-p62s1-43438 branch November 25, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants