Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bare metal: Retrieve error context after crash #12101

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Bare metal: Retrieve error context after crash #12101

merged 1 commit into from
Dec 17, 2019

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Dec 13, 2019 •
edited
Loading

Summary of changes

  • Ensure the function to retrieve the error context after a fatal error is called at
    system initialisation for the baremetal profile. This is also the case when a RTOS
    is present and is therefore expected by the existing Greentea test.
  • Enable Greentea test for the baremetal profile to validate the change.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon @hugueskamba @jamesbeyond

@rajkan01
Fixing the Mbed OS crash reporting and enable green tea test for bare…
f6a7f65 
… metal.

Added missing mbed_error_initialize function call in bare metal boot code which is used
to retrieve the crash report from RAM in case of any previous abnormal re-boot but this function call is present in RTOS boot code.
@hugueskamba
Copy link
Collaborator

The title of the PR (and commit message headline) is not very clear.

I suggest:

Bare metal: Retrieve error context after crash

* Ensure the function to retrieve the error context after a fatal error is called at
  system initialisation for the baremetal profile. This is also the case when a RTOS
  is present and is therefore expected by the existing Greentea test.
* Enable Greentea test for the baremetal profile to validate the change.

@rajkan01 rajkan01 changed the title Fixing the Mbed OS crash reporting and enable green tea test for bare metal Bare metal: Retrieve error context after crash Dec 13, 2019
@kjbracey
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 17, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@adbridge adbridge merged commit 806ad39 into ARMmbed:master Dec 17, 2019
@adbridge adbridge added release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed ready for merge labels Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@kjbracey kjbracey kjbracey approved these changes

@evedon evedon evedon approved these changes

@hugueskamba hugueskamba hugueskamba approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rajkan01 @hugueskamba @kjbracey @mbed-ci @0xc0170 @evedon @adbridge