Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RZ_A1H and GR_LYCHEE: Enable bootloader support #12223

Merged
merged 3 commits into from Jan 17, 2020
Merged

RZ_A1H and GR_LYCHEE: Enable bootloader support #12223

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aad53c2
RZ_A1H: enable bootloader support
d-kato Jan 9, 2020
3a2ab1b
GR_LYCHEE: enable bootloader support
d-kato Jan 9, 2020
b72d0be
Add sector information
d-kato Jan 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions targets/targets.json
View file
Open in desktop
Expand Up @@ -5847,7 +5847,10 @@
"device_has_add": ["USBDEVICE", "EMAC", "FLASH", "LPTICKER"],
"release_versions": ["2", "5"],
"device_name": "R7S72100",
"bootloader_supported": false
"bootloader_supported": true,
"mbed_rom_start" : "0x18000000",
"mbed_rom_size" : "0x800000",
"sectors": [[0,4096]]
},
"VK_RZ_A1H": {
"inherits": ["RZ_A1XX"],
Expand All @@ -5864,7 +5867,10 @@
"device_has_remove": ["ETHERNET"],
"release_versions": ["2", "5"],
"device_name": "R7S72103",
"bootloader_supported": false,
"bootloader_supported": true,
"mbed_rom_start" : "0x18000000",
"mbed_rom_size" : "0x800000",
"sectors": [[0,4096]],
"overrides": {
"network-default-interface-type": null
}
Expand Down
34 changes: 12 additions & 22 deletions tools/arm_pack_manager/index.json
View file
Open in desktop
Expand Up @@ -302969,20 +302969,20 @@
"version": "1.2.1"
},
"memories": {
"PROGRAM_FLASH": {
"IRAM1": {
"access": {
"execute": true,
"non_secure": false,
"non_secure_callable": false,
"peripheral": false,
"read": true,
"secure": false,
"write": false
"write": true
},
"default": true,
"size": 8388608,
"start": 402653184,
"startup": true
"size": 10485760,
"start": 536870912,
"startup": false
}
},
"name": "R7S72100",
Expand All @@ -302994,12 +302994,7 @@
"units": 1
}
},
"sectors": [
[
0,
4096
]
],
"sectors": [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to have some information here, it should be the sector start address and size. Even one entry like previously would do, but in reality the start should be 536870912 and size should be the erase sector size (HW reference should tell that).

Travis CI fails otherwise.

Same for the other board, too.

Copy link
Contributor Author

@d-kato d-kato Jan 10, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary even if only RAM is defined? It seems that other devices do not mention the RAM sector information.
ROM start address, ROM size and sectors have been added to targets.json.
If sectors is described in both index.json and targets.json, does targets.json take precedence? Or will it be merged?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In an idea world, we .json file would be enough, but unfortunately we're not there. RAM does not have to be defined for the sectors, only the flash.

"sub_family": "RZ_A1H",
"vendor": "Renesas:117"
},
Expand All @@ -303013,20 +303008,20 @@
"version": "1.2.1"
},
"memories": {
"PROGRAM_FLASH": {
"IRAM1": {
"access": {
"execute": true,
"non_secure": false,
"non_secure_callable": false,
"peripheral": false,
"read": true,
"secure": false,
"write": false
"write": true
},
"default": true,
"size": 8388608,
"start": 402653184,
"startup": true
"size": 3145728,
"start": 536870912,
"startup": false
}
},
"name": "R7S72103",
Expand All @@ -303038,12 +303033,7 @@
"units": 1
}
},
"sectors": [
[
0,
4096
]
],
"sectors": [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Sectors cannot be empty.

"sub_family": "RZ_A1LU",
"vendor": "Renesas:117"
},
Expand Down