New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RZ_A1H and GR_LYCHEE: Enable bootloader support #12223
Conversation
@d-kato, thank you for your changes. |
tools/arm_pack_manager/index.json
Outdated
4096 | ||
] | ||
], | ||
"sectors": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to have some information here, it should be the sector start address and size. Even one entry like previously would do, but in reality the start should be 536870912 and size should be the erase sector size (HW reference should tell that).
Travis CI fails otherwise.
Same for the other board, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary even if only RAM is defined? It seems that other devices do not mention the RAM sector information.
ROM start address, ROM size and sectors
have been added to targets.json
.
If sectors
is described in both index.json
and targets.json
, does targets.json
take precedence? Or will it be merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In an idea world, we .json file would be enough, but unfortunately we're not there. RAM does not have to be defined for the sectors, only the flash.
tools/arm_pack_manager/index.json
Outdated
4096 | ||
] | ||
], | ||
"sectors": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. Sectors cannot be empty.
Because this device uses external flash, the sector size may vary from board to board. 4096 is set in idex.json as a general serial flash sector size. The exact sector size is listed in targets.json. (This time 4096 same as idex.json) |
This target is only for this board, not for all chips. If someone does a different target, with a different SPI-flash, it should be a custom target and have it's own definitions. Not optimal right now, but that's how it's now. |
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
@JanneKiiskila it's marked for release review as it has to be approved by Andy, Bartek and Neil for consideration for 5.15.2 |
Hi @adbridge, ok for me. |
I approve too @adbridge . |
Marked for 5.15.2 |
@d-kato @JanneKiiskila in order to bring this cleanly to the mbed-os-5.15 branch could we please have an equivalent PR directly to that branch. We are getting PRs directly to that branch with functionality that is either not supported on Master or has deviated and thus we have a diverging code base. By creating an equivalent PR to this directly against that branch will enable us to ensure that the PR lands in time and cleanly. Thanks. We will then move the release version label over to that PR. |
cc @ARMmbed/team-renesas-rz |
@toyowata Code freeze for 5.15.2 is 1 week today so if we do not get an equivalent PR this is unlikely to make it in . cc @JanneKiiskila |
Summary of changes
See #12059. Fixed the following error and re-enabled "bootloader_supported" :
The RAM start address and RAM size are the same for each device. So, the settings are defined in
index.json
of arm_pack_manager.Since an external flash is used, the ROM start address and ROM size are different for each board. So, the settings are defined in
targets.json
.Impact of changes
Migration actions required
Documentation
Not needed
Pull request type
Test results
Reviewers