Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RZ_A1H and GR_LYCHEE: Enable bootloader support #12223

Merged
merged 3 commits into from Jan 17, 2020

Conversation

d-kato
Copy link
Contributor

@d-kato d-kato commented Jan 9, 2020

Summary of changes

See #12059. Fixed the following error and re-enabled "bootloader_supported" :

  • tools.config.ConfigException: Missing a memory that is read, write in CMSIS Pack data
  • "start not found in targets.json.".format(active_memory)

The RAM start address and RAM size are the same for each device. So, the settings are defined in index.json of arm_pack_manager.
Since an external flash is used, the ROM start address and ROM size are different for each board. So, the settings are defined in targets.json.

Impact of changes

Migration actions required

Documentation

Not needed


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom requested review from a team January 9, 2020 10:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 9, 2020

@d-kato, thank you for your changes.
@ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-tools please review.

4096
]
],
"sectors": [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to have some information here, it should be the sector start address and size. Even one entry like previously would do, but in reality the start should be 536870912 and size should be the erase sector size (HW reference should tell that).

Travis CI fails otherwise.

Same for the other board, too.

Copy link
Contributor Author

@d-kato d-kato Jan 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary even if only RAM is defined? It seems that other devices do not mention the RAM sector information.
ROM start address, ROM size and sectors have been added to targets.json.
If sectors is described in both index.json and targets.json, does targets.json take precedence? Or will it be merged?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In an idea world, we .json file would be enough, but unfortunately we're not there. RAM does not have to be defined for the sectors, only the flash.

4096
]
],
"sectors": [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Sectors cannot be empty.

@d-kato
Copy link
Contributor Author

d-kato commented Jan 14, 2020

Because this device uses external flash, the sector size may vary from board to board. 4096 is set in idex.json as a general serial flash sector size. The exact sector size is listed in targets.json. (This time 4096 same as idex.json)

@JanneKiiskila
Copy link
Contributor

This target is only for this board, not for all chips. If someone does a different target, with a different SPI-flash, it should be a custom target and have it's own definitions. Not optimal right now, but that's how it's now.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 17, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 17, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed needs: CI labels Jan 17, 2020
@0xc0170 0xc0170 merged commit 0266a95 into ARMmbed:master Jan 17, 2020
@JanneKiiskila
Copy link
Contributor

@adbridge @0xc0170 - requesting to 5.15.1 patch release.

@JanneKiiskila
Copy link
Contributor

@BartSX @adbridge - can we get this to 5.15.2?

@JanneKiiskila
Copy link
Contributor

JanneKiiskila commented Mar 18, 2020

Requesting to 5.15.x patch release. @adbridge @0xc0170 , can you tag it please? It's still Mbed OS 6.0 only.

@adbridge
Copy link
Contributor

@JanneKiiskila it's marked for release review as it has to be approved by Andy, Bartek and Neil for consideration for 5.15.2

@NeilJackson-AlifSemi
Copy link

Hi @adbridge, ok for me.

@andypowers
Copy link
Collaborator

andypowers commented Mar 19, 2020

I approve too @adbridge .

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 19, 2020

Marked for 5.15.2

@adbridge
Copy link
Contributor

adbridge commented Mar 19, 2020

@d-kato @JanneKiiskila in order to bring this cleanly to the mbed-os-5.15 branch could we please have an equivalent PR directly to that branch. We are getting PRs directly to that branch with functionality that is either not supported on Master or has deviated and thus we have a diverging code base. By creating an equivalent PR to this directly against that branch will enable us to ensure that the PR lands in time and cleanly. Thanks. We will then move the release version label over to that PR.

@toyowata
Copy link
Contributor

cc @ARMmbed/team-renesas-rz

@adbridge
Copy link
Contributor

@toyowata Code freeze for 5.15.2 is 1 week today so if we do not get an equivalent PR this is unlikely to make it in . cc @JanneKiiskila

@toyowata
Copy link
Contributor

toyowata commented Mar 27, 2020

@adbridge I intended to cherry-pick these commits to my remote repo, but accidentally pushed to mbed-os-5.15 branch directly. If this is not right, please remove my commits from the branch. Sorry for the confusion.

RyoheiHagimoto added a commit to RyoheiHagimoto/mbed-os that referenced this pull request Mar 27, 2020
RyoheiHagimoto added a commit to RyoheiHagimoto/mbed-os that referenced this pull request Mar 27, 2020
RyoheiHagimoto added a commit to RyoheiHagimoto/mbed-os that referenced this pull request Mar 30, 2020
RyoheiHagimoto added a commit to RyoheiHagimoto/mbed-os that referenced this pull request Mar 31, 2020
RyoheiHagimoto added a commit to RyoheiHagimoto/mbed-os that referenced this pull request Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants