LPC408X: Delete the ethernet_api.c files #12408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove an obsolete HAL implementation from LPC408X to fix the GCC_ARM build with the "-flto" flag. With the lto enabled, unreferenced buffers defined in ethernet_api.c were not excluded at link time overflowing the 16kB peripheral SRAM1 (ld error: "section '.AHBSRAM1' will not fit in region 'ETH_RAM'"). The Ethernet HAL API is deprecated in favor of EMAC.
0xc0170
approved these changes
Feb 11, 2020
jamesbeyond
approved these changes
Feb 11, 2020
|
Hey @0xc0170, please tag this for alpha-2-release |
mark-edgeworth
approved these changes
Feb 12, 2020
0xc0170
added
the
release-version: 6.0.0-alpha-2
|
CI started |
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
|
The failures are known on master, will restart CI once it is fixed. |
|
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
Job restarted (internal fault) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Remove an obsolete HAL implementation from LPC408X to fix the GCC_ARM build with the
-fltoflag.This has been discussed in and separated from #11856. For more details, please see #11856 (comment). Original description below.
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers
@mark-edgeworth, @jamesbeyond, @kjbracey-arm