Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cellular: ALT1250 PPP cellular driver for mbed-os 5.15 #12650

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Cellular: ALT1250 PPP cellular driver for mbed-os 5.15 #12650

merged 1 commit into from
Apr 8, 2020

Conversation

kivaisan
Copy link
Contributor

@kivaisan kivaisan commented Mar 19, 2020 •
edited
Loading

Summary of changes

This PR introduces Altair ALT1250 PPP mode NB-IoT cellular driver to mbed-os 5.15 -branch.

The same driver has already been merged to master branch with PR #12597, but since cellular APIs has changed in master branch, it is not applicable to 5.15 -branch.

Impact of changes

Migration actions required

Documentation

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/mbed-os-wan

@ciarmcom ciarmcom requested a review from a team March 19, 2020 08:00
@ciarmcom
Copy link
Member

@kivaisan, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

AnttiKauppila
AnttiKauppila previously approved these changes Mar 19, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Mar 19, 2020
@AnttiKauppila
Copy link

@ARMmbed/mbed-os-maintainers Ready for CI

0xc0170
0xc0170 previously approved these changes Mar 19, 2020
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 19, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 19, 2020

Test run: FAILED

Summary: 2 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_greentea-test

@kivaisan
Copy link
Contributor Author

@0xc0170 Those failures do not seem to be related to this PR. Right?

@adbridge
Copy link
Contributor

Please note nothing lands on the 5.15 branch without prior approval from @bulislaw , @fabiomadu and Andy Powers.

@adbridge
Copy link
Contributor

Please note nothing lands on the 5.15 branch without prior approval from @bulislaw , @fabiomadu and Andy Powers.

Confirmed with Andy Powers that this is accepted into 5.15.2

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 19, 2020 •
edited
Loading

@0xc0170 Those failures do not seem to be related to this PR. Right?

dynamic memory usage no, its on master as well. I'm checking tests and restart possibly

@adbridge
Copy link
Contributor

CI restarted

@mbed-ci
Copy link

mbed-ci commented Mar 20, 2020

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@mergify mergify bot added needs: work and removed needs: CI labels Mar 20, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 23, 2020

test restarted

@adbridge
Copy link
Contributor

adbridge commented Apr 2, 2020

@kivaisan looks like this needs a rebase :(

Cellular: ALT1250 PPP cellular driver for mbed-os 5.15
d65b82d 
This commit introduces Altair ALT1250 PPP mode cellular driver for mbed-os 5.15 -branch.
@kivaisan
Copy link
Contributor Author

kivaisan commented Apr 2, 2020

Rebased

@mergify mergify bot dismissed stale reviews from AnttiKauppila and 0xc0170 April 2, 2020 10:12

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 2, 2020

Ci restarted

@mbed-ci
Copy link

mbed-ci commented Apr 2, 2020

Test run: FAILED

Summary: 2 of 3 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM-lts
  • jenkins-ci/mbed-os-ci_build-GCC_ARM-lts

@kivaisan
Copy link
Contributor Author

kivaisan commented Apr 3, 2020

@0xc0170 Build environment does not seem to be right. There's plenty of different kind of build errors not related to this PR (out of disc space, missing secure element header etc.).

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2020

@0xc0170 Build environment does not seem to be right. There's plenty of different kind of build errors not related to this PR (out of disc space, missing secure element header etc.).

@ARMmbed/mbed-os-test

@mbed-ci
Copy link

mbed-ci commented Apr 3, 2020

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test-lts

@mbed-ci
Copy link

mbed-ci commented Apr 3, 2020

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test-lts

@mbed-ci
Copy link

mbed-ci commented Apr 6, 2020

Test run: FAILED

Summary: 1 of 9 test jobs failed
Build number : 7
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test-lts

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 6, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Apr 6, 2020

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 8
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test-lts

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 6, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Apr 6, 2020

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 9
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test-lts

@mbed-ci
Copy link

mbed-ci commented Apr 7, 2020

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 10
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test-lts

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 7, 2020

restarting tests

@mbed-ci
Copy link

mbed-ci commented Apr 7, 2020

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 11
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test-lts

@0xc0170 0xc0170 merged commit eaeb983 into ARMmbed:mbed-os-5.15 Apr 8, 2020
@mergify mergify bot removed the ready for merge label Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila left review comments

Assignees
No one assigned
Labels
release-version: 5.15.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kivaisan @ciarmcom @AnttiKauppila @0xc0170 @mbed-ci @adbridge