-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LTO issue with minimal-printf #12712
Conversation
@jamesbeyond, thank you for your changes. |
This is one of the things for me to look at today, if this fixes it, nightly build can be green again 💯 |
CI started |
Test run: FAILEDSummary: 2 of 6 test jobs failed Failed test jobs:
|
Seems the failures are not related, maybe due to a flaky target in CI? |
tests restarted (if the target is again io serial, we will request test to restart the target or remove) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs testing properly
Yes, they have been tested locally, everything is passed as expected. But what I don't know is when LTO is not in use, still apply those option, is there any side effect? reading gcc docs didn't give very clear answers. That why I suggest leaving these options in this JSON file. rather than put into the build scripts, So these options will only get applied when LTO in use |
Client restarted |
I found a note "Only undefined references are replaced by the linker." in https://sourceware.org/binutils/docs/ld/Options.html. If there are no undefined ref, nothing to replace. Is that case when minimal printf not enabled? |
if minimal-printf is not enabled, then we are not going to give |
@evedon @mark-edgeworth All good here to merge it today? |
ok with me. |
Summary of changes
Minimal-printf is enabled by default now.
However, LTO have some issues when build with minimal-printf.
This PR update lto profile including all printf related wrap functions.
So the Nightly LTO build job will be passed
Impact of changes
Migration actions required
Documentation
Not Requed
Pull request type
Test results
Reviewers