-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLE: RF tester commands (and Cordio unhandled command complete) #13055
Conversation
@paul-szczepanek-arm, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar comment than to another PR, can we extend comment messages? One liner should be purely for simple fixes, this PR adds much more.
…ck was incorrectly picking a define that wasn't even the last in the table. It now uses the size of the table.
…ete events for all commands that it doesn't have a specific handler for. This adds a catch-all handler that allows the user application to handle any command complete that isn't already handled by the stack. This involves adding a new type of event and routing the event through the stack to the device where it's forwarded to the existing event handling in mbed-os.
…allow you to send the HCI commands HCI_LE_Receiver_Test, HCI_LE_Transmitter_Test and HCI_LE_Test_End. The results of the test are obtained by the command complete command for HCI_LE_Test_End and passed to the user by the callback register in the test start calls.
30885c5
to
fbe9312
Compare
As requested I have expanded the commit messages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @paul-szczepanek-arm
CI started |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
All green but the incorrect status reported from mergify makes it red. I'll merge as it can't be overwritten. |
Summary of changes
Added a new optional call in the cordio hci driver that allows users to issues rf tester commands for the ble chip.
New event in the cordio stack for command complete. This allows mbed to handle command complete commands not handled by cordio.
This is needed by the rf tester commands in this PR to work since they need the results returned to them.
Impact of changes
Migration actions required
Documentation
none
Pull request type
Test results
Reviewers
@pan-