Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: RF tester commands (and Cordio unhandled command complete) #13055

Merged
merged 4 commits into from
Jun 10, 2020

Conversation

paul-szczepanek-arm
Copy link
Member

@paul-szczepanek-arm paul-szczepanek-arm commented Jun 2, 2020

Summary of changes

Added a new optional call in the cordio hci driver that allows users to issues rf tester commands for the ble chip.

New event in the cordio stack for command complete. This allows mbed to handle command complete commands not handled by cordio.

This is needed by the rf tester commands in this PR to work since they need the results returned to them.

Impact of changes

Migration actions required

Documentation

none


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[x] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@pan-


@ciarmcom ciarmcom requested review from pan- and a team June 2, 2020 15:00
@ciarmcom
Copy link
Member

ciarmcom commented Jun 2, 2020

@paul-szczepanek-arm, thank you for your changes.
@pan- @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 changed the title [BLE] RF tester commands (and Cordio unhandled command complete) BLE: RF tester commands (and Cordio unhandled command complete) Jun 3, 2020
0xc0170
0xc0170 previously requested changes Jun 3, 2020
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment than to another PR, can we extend comment messages? One liner should be purely for simple fixes, this PR adds much more.

…ck was incorrectly picking a define that wasn't even the last in the table. It now uses the size of the table.
…ete events for all commands that it doesn't have a specific handler for. This adds a catch-all handler that allows the user application to handle any command complete that isn't already handled by the stack. This involves adding a new type of event and routing the event through the stack to the device where it's forwarded to the existing event handling in mbed-os.
…allow you to send the HCI commands HCI_LE_Receiver_Test, HCI_LE_Transmitter_Test and HCI_LE_Test_End. The results of the test are obtained by the command complete command for HCI_LE_Test_End and passed to the user by the callback register in the test start calls.
@mergify mergify bot dismissed 0xc0170’s stale review June 3, 2020 14:23

Pull request has been modified.

@paul-szczepanek-arm
Copy link
Member Author

As requested I have expanded the commit messages.

Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mergify mergify bot added needs: CI and removed needs: work labels Jun 9, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 10, 2020

All green but the incorrect status reported from mergify makes it red. I'll merge as it can't be overwritten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants