BLE: fix direct advertising on Cordio #13060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paul-szczepanek-arm, thank you for your changes. |
0xc0170
reviewed
Jun 3, 2020
pan-
approved these changes
Jun 3, 2020
| if (enable) { | ||
| uint16_t *durations_ms = new uint16_t[number_of_sets]; | ||
| advertising_handle_t handles[DM_NUM_ADV_SETS];; |
|
@paul-szczepanek-arm, thank you for your changes. |
paul-szczepanek-arm
force-pushed
the
direct-advertising
branch
from
fd77f4f
to
ddcf73b
Compare
To start direct connectable advertising on the cordio stack, the programmer should call the function DmConnAccept instead of the function DmAdvStart . This functions expect the target address and address type as parameter, which are passed to the controller when the programmer sets the advertising parameters and not known when advertising_enable is called. Therefore, this information should be kept in memory when advertising parameters are set and retrieved when advertising is enable to choose the right call to start (or stop) advertising. Timeout of direct advertising is also handled in an uncommon way, a connection timeout is received. Similarly, DmConnClose should be called to stop connectable direct advertising. The state is kept in an array of direct_adv_cb_t. Each items contains a peer address, the peer address type, the connection handle and the advertising handle as well as a state which indicate if the advertising is running, pending or not used. When advertising parameters are set, the state is updated to match the target address or disable direct advertising management for the advertising set being configured. When advertising is enabled, the pal dispatch the operation to the right calls (DmAdvStart/DmConnAccept or DmAdvStop/DmConnClose). When an advertising timeout happen or a connection is made, the pal cleans any direct advertising state of this advertising set
paul-szczepanek-arm
force-pushed
the
direct-advertising
branch
from
ddcf73b
to
dd615f7
Compare
pan-
approved these changes
Jun 4, 2020
0xc0170
approved these changes
Jun 8, 2020
|
CI started |
|
Also restarted Travis to report the status |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
|
All green but the incorrect status reported from mergify makes it red. I'll merge as it can't be overwritten. |
0xc0170
added
the
release-type: patch
adbridge
added
release-version: 6.1.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fix support for direct advertising on Cordio.
Impact of changes
Migration actions required
Documentation
none
Pull request type
Test results
Reviewers
@pan-