Add support for Embedded Planet target Atlas #13128
Conversation
|
@farrenv, thank you for your changes. |
| void ONBOARD_TELIT_ME310::press_power_button(int time_ms) | ||
| { | ||
| gpio_t gpio_CELL_ON_OFF; | ||
| //gpio_t gpio_PWR_MON; |
There was a problem hiding this comment.
is this dead code that should not be here? There's lot of code without any further comment.
There was a problem hiding this comment.
Dead code removed. Thanks!
| // gpio_write(&gpio_CELL_ON_OFF, 0); | ||
| // } | ||
|
|
||
| gpio_init_out_ex(&gpio_CELL_ON_OFF, P0_31, 1); |
There was a problem hiding this comment.
these lines need alignment
There was a problem hiding this comment.
Aligned in latest commit. Thanks!
| A5 = p31, | ||
|
|
||
| /**** QSPI pins ****/ | ||
| // QSPI1_IO0 = P0_20, |
There was a problem hiding this comment.
why are these commented out?
There was a problem hiding this comment.
Pinnames file borrowed from Agora. Cleaned up in latest commit. Thanks!
0xc0170
added
the
release-type: patch
|
@farrenv Can you also attached how this was tested (test results as part of PR) ? I'll start CI meanwhile |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
adbridge
added
release-version: 6.1.0
Release-pending
and removed
release-type: patch
Summary of changes
The Embedded Planet target Atlas is a carrier board for the purpose of demonstrating the Embedded Planet Chronos Telit Modem. This PR is adding the Atlas development board support to Mbed OS 6.
Documentation
Depends on #13009#13009 has been added to master.
My branch has been rebased onto master.
Pull request type
Test results
Reviewers
@maclobdell @ARMmbed/team-embeddedplanet