Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in DNS cache #13408

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Conversation

boraozgen
Copy link
Contributor

Summary of changes

Fixes the memory leak that happens when DNS cache is expired (#13398). The address member of dns_cache is forgotten to be freed before freeing the struct.

I did not run any tests on this change, but it fixed the memory leak I was observing using the mbed_stats_heap_get() API. I assume that the scenario of waiting DNS cache expiry is not covered in the tests at all. I checked "Covered by existing mbed-os tests" below but maybe new tests are required to test this scenario.

Impact of changes

Migration actions required

Documentation

No update required.


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 10, 2020
@ciarmcom ciarmcom requested a review from a team August 10, 2020 17:00
@ciarmcom
Copy link
Member

@boraozgen, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 11, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Aug 11, 2020
@mbed-ci
Copy link

mbed-ci commented Aug 11, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 3fc6667 into ARMmbed:master Aug 11, 2020
@mergify mergify bot removed the ready for merge label Aug 11, 2020
@mbedmain mbedmain added release-version: 6.2.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants