-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host privacy implementation #13560
Merged
pan-
merged 14 commits into
ARMmbed:feature-ble-host-privacy
from
pan-:host-privacy-implementation
Sep 9, 2020
Merged
Host privacy implementation #13560
pan-
merged 14 commits into
ARMmbed:feature-ble-host-privacy
from
pan-:host-privacy-implementation
Sep 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
pan-
force-pushed
the
host-privacy-implementation
branch
from
September 9, 2020 15:10
97d0906
to
8c798fd
Compare
This PAL interface is responsible for generating, resolving private address and maintaining the controller or host resolving list. It also indicates to upper level if LL resolution is supported or not and allows them to enable it.
It controls private address generation and host or controller address resolution.
Resolution list has been removed from the pal as this is handled by the PrivateAddressController.
A race condition was present if a single event was present in the event queue and the event was generating a new event.
…to connect to a peer.
pan-
force-pushed
the
host-privacy-implementation
branch
from
September 9, 2020 15:20
8c798fd
to
9e7385a
Compare
pan-
added
release-version: feature branch
and removed
do not merge
needs: preceding PR
release-version: feature branch
labels
Sep 9, 2020
This is a feature branch and it will moved, we're merging this work now and provide remaining features in next PRs. |
paul-szczepanek-arm
approved these changes
Sep 9, 2020
Review of this work was here: https://github.com/pan-/mbed/pull/8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Refactoring of Privacy so it works with controller supporting LL private address resolution and LL private address generation. If not supported by the controller, generation is handled by the host.
The core of this change is the new
PrivateAddressController
class which handles private addresses generation, resolving list management and address resolution.It replaces the PAL previously splitted between the SecurityManager and the Gap PAL.
State:
Preceding PR: #13475
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers